All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Peter Ujfalusi <peter.ujfalusi@nokia.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: Codec driver for Texas Instruments tlv320dac33 codec
Date: Tue, 13 Oct 2009 10:50:58 +0100	[thread overview]
Message-ID: <20091013095058.GA28499@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <200910131246.42861.peter.ujfalusi@nokia.com>

On Tue, Oct 13, 2009 at 12:46:42PM +0300, Peter Ujfalusi wrote:
> On Tuesday 13 October 2009 12:26:22 ext Mark Brown wrote:

> > I think so - it'd probably also help if the cache restore were merged
> > into one of the functions too.  I'd be inclined to keep _power too.

> You mean something like this:
> dac33_set_power -> dac33_hard_power
> dac33_soft_power -> dac33_soft_power

Yes but...

> Or keeping the old names, but make the use of these more consequent?

...also the second bit of this :)

      reply	other threads:[~2009-10-13  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-12 11:48 [PATCH] ASoC: Codec driver for Texas Instruments tlv320dac33 codec Peter Ujfalusi
2009-10-12 11:48 ` [PATCH - try2] ASoC: TPA6130A2: Make tpa6130a2_power as static Peter Ujfalusi
2009-10-12 15:18 ` [PATCH] ASoC: Codec driver for Texas Instruments tlv320dac33 codec Mark Brown
2009-10-13  4:52   ` Eero Nurkkala
2009-10-13  7:12   ` Peter Ujfalusi
2009-10-13  9:26     ` Mark Brown
2009-10-13  9:46       ` Peter Ujfalusi
2009-10-13  9:50         ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091013095058.GA28499@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=peter.ujfalusi@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.