From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Tom Zanussi <tzanussi@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] tracing/profile: Add filter support
Date: Tue, 13 Oct 2009 12:07:08 +0200 [thread overview]
Message-ID: <20091013100708.GD26846@elte.hu> (raw)
In-Reply-To: <4AD3E3B5.70502@cn.fujitsu.com>
* Li Zefan <lizf@cn.fujitsu.com> wrote:
> +#ifdef CONFIG_EVENT_PROFILE
> +struct perf_event;
> +extern int ftrace_profile_enable(int event_id);
> +extern void ftrace_profile_disable(int event_id);
> +extern int ftrace_profile_set_filter(struct perf_event *event, int event_id,
> + char *filter_str);
> +extern void ftrace_profile_free_filter(struct perf_event *event);
> +#endif
This reminds me - i think we should eliminate CONFIG_EVENT_PROFILE -
it's an unnecessary Kconfig complication. If both PERF_EVENTS and
EVENT_TRACING is enabled we should expose generic tracepoints.
Nor is it limited to event 'profiling', so it has become a misnomer as
well.
Ingo
next prev parent reply other threads:[~2009-10-13 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 2:17 [PATCH 0/4] perf trace: Add filter Suppport, V2 Li Zefan
2009-10-13 2:18 ` [PATCH 1/4] tracing/filters: Refactor subsystem filter code Li Zefan
2009-10-13 2:18 ` [PATCH 2/4] tracing/filters: Use a different op for glob match Li Zefan
2009-10-13 2:19 ` [PATCH 3/4] tracing/profile: Add filter support Li Zefan
2009-10-13 9:16 ` Peter Zijlstra
2009-10-13 9:23 ` Li Zefan
2009-10-13 10:07 ` Ingo Molnar [this message]
2009-10-13 2:20 ` [PATCH 4/4] perf trace: Add filter Suppport Li Zefan
-- strict thread matches above, loose matches on Subject: below --
2009-10-15 3:19 [PATCH 0/4] perf trace: Add filter Suppport, V3 Li Zefan
2009-10-15 3:21 ` [PATCH 3/4] tracing/profile: Add filter support Li Zefan
2009-10-15 9:47 ` Américo Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013100708.GD26846@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.