From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH qemu-kvm] Enable UFO on virtio-net and tap devices Date: Tue, 13 Oct 2009 12:35:27 -0300 Message-ID: <20091013153527.GA5940@amt.cnet> References: <1254952242.31575.179.camel@w-sridhar.beaverton.ibm.com> <1254996477.8069.17.camel@blaa> <1255041101.20627.51.camel@w-sridhar.beaverton.ibm.com> <1255072288.2786.13.camel@blaa> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sridhar Samudrala , avi@redhat.com, aliguori@us.ibm.com, kvm@vger.kernel.org To: Mark McLoughlin Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39471 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760505AbZJMQaM (ORCPT ); Tue, 13 Oct 2009 12:30:12 -0400 Content-Disposition: inline In-Reply-To: <1255072288.2786.13.camel@blaa> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Oct 09, 2009 at 08:11:28AM +0100, Mark McLoughlin wrote: > On Thu, 2009-10-08 at 15:31 -0700, Sridhar Samudrala wrote: > > On Thu, 2009-10-08 at 11:07 +0100, Mark McLoughlin wrote: > > > On Wed, 2009-10-07 at 14:50 -0700, Sridhar Samudrala wrote: > > > > linux 2.6.32 includes UDP fragmentation offload support in software. > > > > So we can enable UFO on the host tap device if supported and allow setting > > > > UFO on virtio-net in the guest. > > > > > > Hmm, we really need to detect whether the host has tuntap UFO support > > > before advertising it to the guest. Maybe in net_tap_fd_init() we should > > > toggle TUN_F_UFO back and forth and check for EINVAL? > > > > Sure. Here is an updated patch that checks for UFO support in host. > > Looks good to me, thanks > > Acked-by: Mark McLoughlin Applied, thanks.