From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <menon.nishanth@gmail.com>
Cc: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>,
"Pandita, Vikram" <vikram.pandita@ti.com>,
"Menon, Nishanth" <nm@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
Sanjeev Premi <premi@ti.com>
Subject: Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero
Date: Tue, 13 Oct 2009 10:15:11 -0700 [thread overview]
Message-ID: <20091013171511.GS12700@atomide.com> (raw)
In-Reply-To: <4AD452F1.7000309@gmail.com>
* Nishanth Menon <menon.nishanth@gmail.com> [091013 03:44]:
> Shilimkar, Santosh said the following on 10/13/2009 05:03 AM:
> > Has anybody tried building latest linux-omap master ? The build is breaking for other OMAP processors.
> >
> > CC arch/arm/mach-omap2/id.o
> > arch/arm/mach-omap2/id.c: In function 'omap3_cpuinfo':
> > arch/arm/mach-omap2/id.c:269: error: implicit declaration of function 'cpu_is_omap3630'
> > make[1]: *** [arch/arm/mach-omap2/id.o] Error 1
> > make: *** [arch/arm/mach-omap2] Error 2
> >
> > This is because of " 0a9b95f21995aa3cdda82ebc6e77b0b2ab401861"
> > omap: Introduce OMAP3630
> >
> > Below patch from Vikram fixes the build break.
> >
> ouch.. my bad.. thanks for answering my question. I am guessing we need
> this coz of is_omap3630() translation..
> Ack for the patch from me.
To me it looks like all the 35x defines need the same treatment.
Tony
next prev parent reply other threads:[~2009-10-13 17:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-12 20:51 [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Vikram Pandita
2009-10-12 21:05 ` Menon, Nishanth
2009-10-12 21:07 ` Pandita, Vikram
2009-10-12 21:09 ` Menon, Nishanth
2009-10-13 10:03 ` Shilimkar, Santosh
2009-10-13 10:14 ` Nishanth Menon
2009-10-13 17:15 ` Tony Lindgren [this message]
2009-10-13 17:43 ` [PATCH] omap: Fix cpu_is_omap35xx default defines (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 17:18 ` [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero Tony Lindgren
2009-10-13 17:32 ` [PATCH] omap: Fix 35xx detection (Re: [PATCH] [RFC] omap: 3630: default cpu_is_omap3630 to zero) Tony Lindgren
2009-10-13 18:31 ` Nishanth Menon
2009-10-13 19:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091013171511.GS12700@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=menon.nishanth@gmail.com \
--cc=nm@ti.com \
--cc=premi@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=vikram.pandita@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.