Re: [PATCH 2/2] i2c-bfin-twi: add debug output for error status

[Ben Dooks <ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>]

On Wed, Oct 07, 2009 at 11:38:16PM -0400, Mike Frysinger wrote:
> From: Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> 
> Add some debug() code to decode the error register.

are you sure you want such verbose debug, if someone issues a bus-scan
then you'll be in for a treat of debuggyness.
 
> Signed-off-by: Michael Hennerich <michael.hennerich-OyLXuOCK7orQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Mike Frysinger <vapier-aBrp7R+bbdUdnm+yROfE0A@public.gmane.org>
> ---
>  drivers/i2c/busses/i2c-bfin-twi.c |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-bfin-twi.c b/drivers/i2c/busses/i2c-bfin-twi.c
> index bbce6bd..be85e3d 100644
> --- a/drivers/i2c/busses/i2c-bfin-twi.c
> +++ b/drivers/i2c/busses/i2c-bfin-twi.c
> @@ -156,6 +156,18 @@ static void bfin_twi_handle_interrupt(struct bfin_twi_iface *iface)
>  		write_MASTER_CTL(iface, 0);
>  		SSYNC();
>  		iface->result = -EIO;
> +
> +		if (mast_stat & LOSTARB)
> +			dev_dbg(&iface->adap.dev, "Lost Arbitration\n");
> +		if (mast_stat & ANAK)
> +			dev_dbg(&iface->adap.dev, "Address Not Acknowledged\n");
> +		if (mast_stat & DNAK)
> +			dev_dbg(&iface->adap.dev, "Data Not Acknowledged\n");
> +		if (mast_stat & BUFRDERR)
> +			dev_dbg(&iface->adap.dev, "Buffer Read Error\n");
> +		if (mast_stat & BUFWRERR)
> +			dev_dbg(&iface->adap.dev, "Buffer Write Error\n");
> +
>  		/* if both err and complete int stats are set, return proper
>  		 * results.
>  		 */
> -- 
> 1.6.5.rc2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'