From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1My3CD-0005Ux-LI for mharc-grub-devel@gnu.org; Wed, 14 Oct 2009 08:43:13 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1My3CC-0005UZ-Hx for grub-devel@gnu.org; Wed, 14 Oct 2009 08:43:12 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1My3C8-0005R8-Po for grub-devel@gnu.org; Wed, 14 Oct 2009 08:43:12 -0400 Received: from [199.232.76.173] (port=46013 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1My3C8-0005Qr-Iv for grub-devel@gnu.org; Wed, 14 Oct 2009 08:43:08 -0400 Received: from smarthost03.mail.zen.net.uk ([212.23.3.142]:54564) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1My3C7-0008G9-Rk for grub-devel@gnu.org; Wed, 14 Oct 2009 08:43:08 -0400 Received: from [82.69.40.219] (helo=riva.pelham.vpn.ucam.org) by smarthost03.mail.zen.net.uk with esmtp (Exim 4.63) (envelope-from ) id 1My3C6-0002pn-3Q for grub-devel@gnu.org; Wed, 14 Oct 2009 12:43:06 +0000 Received: from cjwatson by riva.pelham.vpn.ucam.org with local (Exim 3.36 #1 (Debian)) for grub-devel@gnu.org id 1My3C5-0004ME-00; Wed, 14 Oct 2009 13:43:05 +0100 Date: Wed, 14 Oct 2009 13:43:05 +0100 From: Colin Watson To: The development of GRUB 2 Message-ID: <20091014124304.GC28534@riva.ucam.org> References: <20091014122848.GA29883@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091014122848.GA29883@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) X-Originating-Smarthost03-IP: [82.69.40.219] X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Refer to kernel of FreeBSD as "kFreeBSD" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 12:43:12 -0000 On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote: > Note: Some string lengths were hardcoded, and they're being replaced with > sizeof() statements. I triple-checked them for off-by-one mistakes, but it > doesn't hurt if someone else reviews it. Please avoid hardcoding constant > string lengths! It makes it more error-prone to change those strings later. I reviewed the string code and it looks fine. -- Colin Watson [cjwatson@ubuntu.com]