All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Chris Mason <chris.mason@oracle.com>,
	Christoph Hellwig <hch@lst.de>,
	linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: enable discard support
Date: Wed, 14 Oct 2009 15:32:03 +0200	[thread overview]
Message-ID: <20091014133203.GA14011@lst.de> (raw)
In-Reply-To: <20091014132704.GG7850@think>

On Wed, Oct 14, 2009 at 09:27:04AM -0400, Chris Mason wrote:
> On Wed, Oct 14, 2009 at 03:03:02AM +0200, Christoph Hellwig wrote:
> > The discard support code in btrfs currently is guarded by ifdefs for
> > BIO_RW_DISCARD, which is never defines as it's the name of an enum
> > memeber.  Just remove the useless ifdefs to actually enable the code.
> 
> Thanks Christoph,
> 
> Any objection to me reordering these?  That way someone bisecting around
> won't hit discard support without expecting it.

I'm perfectly fine with reordering them.


      reply	other threads:[~2009-10-14 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14  1:03 [PATCH 1/2] btrfs: enable discard support Christoph Hellwig, Christoph Hellwig
2009-10-14 13:27 ` Chris Mason
2009-10-14 13:32   ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091014133203.GA14011@lst.de \
    --to=hch@lst.de \
    --cc=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.