From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1My72o-0002yb-3O for mharc-grub-devel@gnu.org; Wed, 14 Oct 2009 12:49:46 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1My72m-0002w6-1n for grub-devel@gnu.org; Wed, 14 Oct 2009 12:49:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1My72h-0002qR-Lk for grub-devel@gnu.org; Wed, 14 Oct 2009 12:49:43 -0400 Received: from [199.232.76.173] (port=51466 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1My72h-0002q4-BJ for grub-devel@gnu.org; Wed, 14 Oct 2009 12:49:39 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:36994 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1My72g-00015R-Ba for grub-devel@gnu.org; Wed, 14 Oct 2009 12:49:38 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1My72e-0001YR-Ht for grub-devel@gnu.org; Wed, 14 Oct 2009 18:49:36 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1My72d-0000Uj-SP for grub-devel@gnu.org; Wed, 14 Oct 2009 18:49:35 +0200 Date: Wed, 14 Oct 2009 18:49:35 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091014164935.GC1739@thorin> References: <20091014122848.GA29883@thorin> <20091014124304.GC28534@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091014124304.GC28534@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Refer to kernel of FreeBSD as "kFreeBSD" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2009 16:49:44 -0000 On Wed, Oct 14, 2009 at 01:43:05PM +0100, Colin Watson wrote: > On Wed, Oct 14, 2009 at 02:28:48PM +0200, Robert Millan wrote: > > Note: Some string lengths were hardcoded, and they're being replaced with > > sizeof() statements. I triple-checked them for off-by-one mistakes, but it > > doesn't hurt if someone else reviews it. Please avoid hardcoding constant > > string lengths! It makes it more error-prone to change those strings later. > > I reviewed the string code and it looks fine. Thanks Colin. I committed this. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."