Re: [PATCH 01/26] statd: Replace note() with xlog() in rpc.statd

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Oct 13, 2009 at 10:54:16AM -0400, Chuck Lever wrote:
> diff --git a/utils/statd/misc.c b/utils/statd/misc.c
> index 7256291..44af30e 100644
> --- a/utils/statd/misc.c
> +++ b/utils/statd/misc.c
> @@ -29,8 +29,7 @@ xmalloc (size_t size)
>      return ((void *)NULL);
>  
>    if (!(ptr = malloc (size)))
> -    /* SHIT!  SHIT!  SHIT! */
> -    die ("malloc failed");
> +    xlog_err ("malloc failed");

Minor comment, no need to fix now, but: with the name "die" it was a lot
more obvious that this function never returned.

Also future work (not a problem with this patch): it's irritating that
we have long-running daemons dying on memory allocation failures.
Wouldn't it be better if they failed just the current operation and
tried to keep going?

--b.