All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Colin Leroy <colin@colino.net>, Tim Shepard <shep@alum.mit.edu>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: [PATCH] therm_adt746x: Don't access non-existing register
Date: Wed, 14 Oct 2009 17:31:32 +0200	[thread overview]
Message-ID: <20091014173132.2894d0fd@hyperion.delvare> (raw)

The ADT746x don't have any register at sub-address 0, so better use an
existing register for the initial test read.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Colin Leroy <colin@colino.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
---
Tim, I don't really expect this to solve your problem, but who knows...
Care to give it a try, just in case?

 drivers/macintosh/therm_adt746x.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.32-rc4.orig/drivers/macintosh/therm_adt746x.c	2009-10-12 11:53:59.000000000 +0200
+++ linux-2.6.32-rc4/drivers/macintosh/therm_adt746x.c	2009-10-14 17:27:46.000000000 +0200
@@ -387,7 +387,7 @@ static int probe_thermostat(struct i2c_c
 	i2c_set_clientdata(client, th);
 	th->clt = client;
 
-	rc = read_reg(th, 0);
+	rc = read_reg(th, CONFIG_REG);
 	if (rc < 0) {
 		dev_err(&client->dev, "Thermostat failed to read config!\n");
 		kfree(th);


-- 
Jean Delvare

             reply	other threads:[~2009-10-14 15:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 15:31 Jean Delvare [this message]
2009-10-14 18:59 ` [PATCH] therm_adt746x: Don't access non-existing register Tim Shepard
  -- strict thread matches above, loose matches on Subject: below --
2009-12-02  8:19 Jean Delvare
2009-12-02  8:54 ` Michel Dänzer
2009-12-02  9:10   ` Jean Delvare
2009-12-03 10:24     ` Michel Dänzer
2009-12-03 12:03       ` Jean Delvare
2009-12-07 22:13       ` Darrick J. Wong
2009-12-04  2:40 ` Benjamin Herrenschmidt
2009-12-04  9:34   ` Jean Delvare
2009-12-04  9:59     ` Benjamin Herrenschmidt
2009-12-04 10:20     ` Colin Leroy
2009-12-04 10:42       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091014173132.2894d0fd@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=colin@colino.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=shep@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.