All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: lenb@kernel.org
Cc: shaohua.li@intel.com, linux-kernel@vger.kernel.org,
	linux-acpi@vger.kernel.org
Subject: [PATCH v2 3/6] ACPI: dock: remove global 'dock_device_name'
Date: Wed, 14 Oct 2009 16:46:26 -0600	[thread overview]
Message-ID: <20091014224626.18044.41454.stgit@bob.kio> (raw)
In-Reply-To: <20091014224415.18044.88208.stgit@bob.kio>

We only use it in one spot, so it probably gets optimized out, but there's
still no need to use a global variable for this.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 drivers/acpi/dock.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c
index 10cf833..e57be55 100644
--- a/drivers/acpi/dock.c
+++ b/drivers/acpi/dock.c
@@ -50,7 +50,6 @@ MODULE_PARM_DESC(immediate_undock, "1 (default) will cause the driver to "
 	" before undocking");
 
 static struct atomic_notifier_head dock_notifier_list;
-static char dock_device_name[] = "dock";
 
 static const struct acpi_device_id dock_device_ids[] = {
 	{"LNXDOCK", 0},
@@ -951,7 +950,7 @@ static int dock_add(acpi_handle handle)
 
 	/* initialize platform device stuff */
 	dock_station->dock_device =
-		platform_device_register_simple(dock_device_name,
+		platform_device_register_simple("dock",
 			dock_station_count, NULL, 0);
 	dock_device = dock_station->dock_device;
 	ret = IS_ERR(dock_device) ? PTR_ERR(dock_device) : 0;


  parent reply	other threads:[~2009-10-14 22:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 22:46 [PATCH v2 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-14 22:46 ` [PATCH v2 1/6] ACPI: dock: clean up error handling paths in dock_add() Alex Chiang
2009-10-16  4:36   ` Dmitry Torokhov
2009-10-16 20:50     ` Alex Chiang
2009-10-14 22:46 ` [PATCH v2 2/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-14 22:46 ` Alex Chiang [this message]
2009-10-14 22:46 ` [PATCH v2 4/6] ACPI: dock: dock_add - hoist up platform_device_register_simple() Alex Chiang
2009-10-14 22:46 ` [PATCH v2 5/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-14 22:46 ` [PATCH v2 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091014224626.18044.41454.stgit@bob.kio \
    --to=achiang@hp.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.