From: Jens Axboe <jens.axboe@oracle.com>
To: Kenneth Waters <kwaters@google.com>
Cc: fio@vger.kernel.org
Subject: Re: [PATCH] Fix bug in bssplit parsing
Date: Thu, 15 Oct 2009 07:15:11 +0200 [thread overview]
Message-ID: <20091015051511.GY9228@kernel.dk> (raw)
In-Reply-To: <7ce25bc50910141515y3f43f6c1xdb903594377a51c0@mail.gmail.com>
On Wed, Oct 14 2009, Kenneth Waters wrote:
> Fio,
>
> I found a bug is bssplit parsing in bssplit_ddir() when trying to use
> FIO on an ARM platform. It looks like str_to_decimal() takes a "void
> *" as its fourth argument, which it passes to get_multi_bytes(), which
> is passes to fio_get_kb_base(), which casts it to a "struct
> thread_data *". bssplit_ddir() is passing in "struct thread_data **",
> which I think is causing fio_get_kb_base() to go paw around in the
> stack; I believe the different stack layouts between ARM and x86 is
> causing me to see this problem. The first change that introduces this
> bug seems to be d6978a3242daad9cb7b0710b724f19225d1ed7e2.
Woops indeed, good catch! I have applied your patch. Thanks a lot.
> I apologize if this patch is in the wrong format.
It was line wrapped, but not a big deal to correct for a one-liner
patch.
--
Jens Axboe
prev parent reply other threads:[~2009-10-15 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 22:15 [PATCH] Fix bug in bssplit parsing Kenneth Waters
2009-10-15 5:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091015051511.GY9228@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=fio@vger.kernel.org \
--cc=kwaters@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.