All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/2] ocfs2:  Some patches for reflink. v3
Date: Thu, 15 Oct 2009 02:21:07 -0700	[thread overview]
Message-ID: <20091015092106.GD14500@mail.oracle.com> (raw)
In-Reply-To: <4AD691CD.4080400@oracle.com>

On Thu, Oct 15, 2009 at 11:06:53AM +0800, Tao Ma wrote:
> 	This patch set integrate the fix for the bug tristan found.

	These both look good.  You know, if an inode is inline and has
no xattrs, ie:

(oi->i_dyn_flags & (OCFS2_HAS_XATTR_FL | OCFS2_HAS_INLINE_DATA_FL)) ==
  OCFS2_HAS_INLINE_DATA_FL

you can just skip the refcount tree entirely.  Copy the inode.  Reinit
the security if !preserve.  Call it a day.
	But this is a later optimization.

Joel

-- 

Life's Little Instruction Book #450

	"Don't be afraid to say, 'I need help.'"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127

  parent reply	other threads:[~2009-10-15  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-15  3:06 [Ocfs2-devel] [PATCH 0/2] ocfs2: Some patches for reflink. v3 Tao Ma
2009-10-15  3:10 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Move ocfs2_complete_reflink to the right place Tao Ma
2009-10-15  3:10 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: duplicate inline data properly during reflink Tao Ma
2009-10-15  9:21 ` Joel Becker [this message]
2009-10-15 22:18   ` [Ocfs2-devel] [PATCH 0/2] ocfs2: Some patches for reflink. v3 TaoMa
2009-10-16  2:22 ` tristan.ye
2009-10-29  5:44   ` Joel Becker
2009-10-29  6:03 ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091015092106.GD14500@mail.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.