From: Ralf Baechle <ralf@linux-mips.org>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
lkml <linux-kernel@vger.kernel.org>,
linux-mips <linux-mips@linux-mips.org>,
Chungki woo <chungki.woo@gmail.com>
Subject: Re: BUG? linux-mips flush_dcache_page
Date: Fri, 16 Oct 2009 11:24:18 +0200 [thread overview]
Message-ID: <20091016092418.GA3686@linux-mips.org> (raw)
In-Reply-To: <20091016141719.de606482.minchan.kim@barrios-desktop>
On Fri, Oct 16, 2009 at 02:17:19PM +0900, Minchan Kim wrote:
> Many code of kernel fs usually allocate high page and flush.
> But flush_dcache_page of mips checks PageHighMem to avoid flush
> so that data consistency is broken, I think.
What processor and cache configuration?
> I found it's by you and Atsushi-san on 585fa724.
> Why do we need the check?
> Could you elaborte please?
The if statement exists because __flush_dcache_page would crash if a page
is not mapped. This of course isn't correct but that wasn't a problem
since highmem still is only supported on machines that don't have aliases.
Ralf
next prev parent reply other threads:[~2009-10-16 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-16 5:17 BUG? linux-mips flush_dcache_page Minchan Kim
2009-10-16 9:24 ` Ralf Baechle [this message]
2009-10-16 10:43 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091016092418.GA3686@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=chungki.woo@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.