From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1MyraZ-0005tK-SA for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 14:31:43 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyraX-0005t4-1f for grub-devel@gnu.org; Fri, 16 Oct 2009 14:31:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyraR-0005og-OH for grub-devel@gnu.org; Fri, 16 Oct 2009 14:31:39 -0400 Received: from [199.232.76.173] (port=59569 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyraR-0005oH-Gw for grub-devel@gnu.org; Fri, 16 Oct 2009 14:31:35 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:45497 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyraR-00059m-5J for grub-devel@gnu.org; Fri, 16 Oct 2009 14:31:35 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1MyraO-0002Tc-N5 for grub-devel@gnu.org; Fri, 16 Oct 2009 20:31:32 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1MyraN-0001pg-Vi for grub-devel@gnu.org; Fri, 16 Oct 2009 20:31:31 +0200 Date: Fri, 16 Oct 2009 20:31:31 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091016183131.GA7037@thorin> References: <20090826003427.GD25183@thorin> <4AD8524F.3090801@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD8524F.3090801@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Let user specify OpenBSD root device. X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 18:31:41 -0000 On Fri, Oct 16, 2009 at 01:00:31PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Vladimir 'phcoder' Serbinenko wrote: > > On Wed, Aug 26, 2009 at 2:34 AM, Robert Millan wrote: > > > >> On Tue, Aug 25, 2009 at 10:37:33PM +0200, Vladimir 'phcoder' Serbinenko wrote: > >> > >>> + if (cmd->state[OPENBSD_ROOT_ARG].set) > >>> + { > >>> + const char *arg = cmd->state[OPENBSD_ROOT_ARG].arg; > >>> + int unit, part; > >>> + if (*(arg++) != 'w' || *(arg++) != 'd') > >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, > >>> + "Only device specifications of form " > >>> + "wd are supported."); > >>> + > >>> + unit = grub_strtoul (arg, (char **) &arg, 10); > >>> + if (! (arg && *arg >= 'a' && *arg <= 'z')) > >>> + return grub_error (GRUB_ERR_BAD_ARGUMENT, > >>> + "Only device specifications of form " > >>> + "wd are supported."); > >>> > >> Looks like the first error string could be used for both cases, saving > >> a few bytes. > >> > >> > This was fixed. Can this patch be comitted before release to avoid > changing command syntax after release? Ok. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."