From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Myu1L-0000es-4d for mharc-grub-devel@gnu.org; Fri, 16 Oct 2009 17:07:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Myu1J-0000e8-Gt for grub-devel@gnu.org; Fri, 16 Oct 2009 17:07:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Myu1F-0000bs-QN for grub-devel@gnu.org; Fri, 16 Oct 2009 17:07:29 -0400 Received: from [199.232.76.173] (port=39437 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Myu1F-0000bj-Kd for grub-devel@gnu.org; Fri, 16 Oct 2009 17:07:25 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:51656 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Myu1F-0005YP-5V for grub-devel@gnu.org; Fri, 16 Oct 2009 17:07:25 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Myu1D-00032e-GA for grub-devel@gnu.org; Fri, 16 Oct 2009 23:07:23 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Myu1C-0002Jp-S4 for grub-devel@gnu.org; Fri, 16 Oct 2009 23:07:22 +0200 Date: Fri, 16 Oct 2009 23:07:22 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091016210722.GA8866@thorin> References: <20090812003800.GC8561@thorin> <20090813203736.GH22130@thorin> <20090813210506.GS22130@thorin> <4AD851E2.6020104@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD851E2.6020104@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [RFT,PATCH] Move embedding to appropriate partmap files X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 16 Oct 2009 21:07:29 -0000 On Fri, Oct 16, 2009 at 12:58:42PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Thu, Aug 13, 2009 at 10:53:23PM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > >>>> We may want to embed more in the future. Actually I think it's not > >>>> ad-hoc. Basically partition map defines a function which gives back > >>>> the sectors available for embedding. > >>>> > >>> Is embedding useful elsewhere? > >>> > >> Yes. Consider a world of checksummed filesystems. In such world you > >> can't change the contents of the file by just writing to its blocklist > >> since it will break the checksum. Similar problems exist with RAIDs > >> and LVMs. On some systems we can't put grub-env in a file. For these > >> cases we can embed grub-env somewhere where we can write it with ease > >> > > > > Ok. Feel free to use partmap/ then. But please make sure #ifdefs only > > enable those functions where they are going to be used. That'd be > > GRUB_MACHINE_PCBIOS for now, if later code in other ports relies on them, > > this can be changed. > > > > > This patch fixes an important bug - namely overwriting extended > partition tables Is there a simpler way to resolve this? I don't object to the restructuring you propose, but it seems too intrusive to do this just a few hours before we release 1.97. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."