From mboxrd@z Thu Jan 1 00:00:00 1970 From: akpm@linux-foundation.org Subject: + hvc_console-fix-test-on-unsigned-in-hvc_console_print.patch added to -mm tree Date: Fri, 16 Oct 2009 14:13:45 -0700 Message-ID: <200910162113.n9GLDjCS019378@imap1.linux-foundation.org> Reply-To: linux-kernel@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:49803 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbZJPVN4 (ORCPT ); Fri, 16 Oct 2009 17:13:56 -0400 Sender: mm-commits-owner@vger.kernel.org List-Id: mm-commits@vger.kernel.org To: mm-commits@vger.kernel.org Cc: roel.kluin@gmail.com, benh@kernel.crashing.org, borntraeger@de.ibm.com, brueckner@linux.vnet.ibm.com The patch titled hvc_console: fix test on unsigned in hvc_console_print() has been added to the -mm tree. Its filename is hvc_console-fix-test-on-unsigned-in-hvc_console_print.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/SubmitChecklist when testing your code *** See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find out what to do about this The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: hvc_console: fix test on unsigned in hvc_console_print() From: Roel Kluin vtermnos[] is unsigned, so this test was wrong. Signed-off-by: Roel Kluin Cc: Benjamin Herrenschmidt Cc: Hendrik Brueckner Cc: Christian Borntraeger Signed-off-by: Andrew Morton --- diff -puN drivers/char/hvc_console.c~hvc_console-fix-test-on-unsigned-in-hvc_console_print drivers/char/hvc_console.c --- a/drivers/char/hvc_console.c~hvc_console-fix-test-on-unsigned-in-hvc_console_print +++ a/drivers/char/hvc_console.c @@ -146,7 +146,7 @@ static void hvc_console_print(struct con return; /* This console adapter was removed so it is not usable. */ - if (vtermnos[index] < 0) + if (vtermnos[index] == -1) return; while (count > 0 || i > 0) { _ Patches currently in -mm which might be from roel.kluin@gmail.com are linux-next.patch fujitsu-laptop-fix-tests-of-acpi_evaluate_integer-return.patch omap-fix-unlikelyx-y.patch powernow-k8-fix-test-in-get_transition_latency.patch powerpc-sky-cpu-redundant-or-incorrect-tests-on-unsigned.patch hfc_usb-fix-read-buffer-overflow.patch hisax-fix-test-in-waitforxfw.patch drivers-scsi-fnic-fnic_scsic-clean-up.patch ibmmca-buffer-overflow.patch scsi-eata-fix-buffer-overflow.patch drivers-scsi-gdthc-fix-buffer-overflow.patch drivers-scsi-u14-34fc-fix-uffer-overflow.patch drivers-scsi-lpfc-lpfc_vportc-fix-read-buffer-overflow.patch osst-fix-read-buffer-overflow.patch gdth-unmap-ccb_phys-when-scsi_add_host-fails-in-gdth_eisa_probe_one.patch zfcp-test-kmalloc-failure-in-scsi_get_vpd_page.patch st-fix-test-of-value-range-in-st_set_options.patch ncr5380-bit-mr_dma_mode-set-twice-in-ncr5380_transfer_dma.patch bfa-fix-test-in-bfad_os_fc_host_init.patch drivers-staging-octeon-ethernet-rgmiic-dont-ignore-request_irq-return-code.patch page-types-unsigned-cannot-be-less-than-0-in-add_page.patch frv-duplicate-output_buffer-of-e03.patch frv-duplicate-output_buffer-of-e03-checkpatch-fixes.patch cryptocop-fix-assertion-in-create_output_descriptors.patch gpio-fix-test-on-unsigned-in-lnw_irq_type.patch fbdev-tv_paln-bit-set-twice-in-sisfb_detect_vb_connect.patch hvc_console-fix-test-on-unsigned-in-hvc_console_print.patch irq-fix-test-in-__exit-parport_mfc3_exit.patch