From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz6Fv-0005JV-KM for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 06:11:23 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz6Fs-0005J2-UH for grub-devel@gnu.org; Sat, 17 Oct 2009 06:11:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz6Fo-0005Ia-8i for grub-devel@gnu.org; Sat, 17 Oct 2009 06:11:20 -0400 Received: from [199.232.76.173] (port=45657 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz6Fn-0005IX-T8 for grub-devel@gnu.org; Sat, 17 Oct 2009 06:11:15 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:60943 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mz6Fn-0003IF-H6 for grub-devel@gnu.org; Sat, 17 Oct 2009 06:11:15 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mz6Fi-0007Fw-Rj; Sat, 17 Oct 2009 12:11:11 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mz6Fi-0002x4-84; Sat, 17 Oct 2009 12:11:10 +0200 Date: Sat, 17 Oct 2009 12:11:10 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091017101110.GA11305@thorin> References: <20091012.032838.82254107.davem@davemloft.net> <4AD70E53.80004@gmail.com> <1255646501.13480.32.camel@mj> <20091016.054440.193711272.davem@davemloft.net> <1255742496.2746.26.camel@mj> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1255742496.2746.26.camel@mj> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: phcoder@gmail.com, bean123ch@gmail.com, David Miller Subject: Re: powerpc/sparc problems X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 10:11:21 -0000 On Fri, Oct 16, 2009 at 09:21:36PM -0400, Pavel Roskin wrote: > On Fri, 2009-10-16 at 05:44 -0700, David Miller wrote: > > > > They worked perfectly fine for me on a real system with > > a real compiler and glibc. > > > > If you're going to use cross compilation to test, use > > a full cross toolset and glibc build not some hacked > > up uclibc thing. But we're testing a feature of libgcc, not glibc. > I have tested the current GRUB on PowerPC. It's Fedora 11 with a real > glibc. I added __ashldi3 to the arguments of AC_CHECK_FUNCS. The check > fails. Yet __ashldi3 is present in libgcc and is exported > unconditionally. > > The reason is that -nostdlib is added to CFLAGS immediately above > AC_CHECK_FUNCS. -nostdlib disables linking against libgcc. > > I believe the checks for __bswapsi2 __bswapdi2 would fail on sparc64 for > the same reason. Then why not just add -lgcc after -nostdlib? > I'm surprised that my code is being reverted immediately before the > release and the result is not tested. I was under the impression that there was consensus that it should be reverted. Excuse me for not having tracked this more closely. Looking at 2631:2632, it seems to me that: - Using configure checks is the right way, we just need to make them work (I think -lgcc should do it). - The ifdef wraps that have been added to sparc64/libgcc.h should also be in powerpc/libgcc.h. > It's one thing to revert the code > that has just been committed, and it's entirely different when the code > has been in the repository for months. Yes. There's been a long freeze period during which it'd have been more appropiate to discuss this kind of things... -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."