From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Mz7xU-00017t-4p for mharc-grub-devel@gnu.org; Sat, 17 Oct 2009 08:00:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mz7xS-00017Y-KT for grub-devel@gnu.org; Sat, 17 Oct 2009 08:00:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mz7xN-00015a-21 for grub-devel@gnu.org; Sat, 17 Oct 2009 08:00:25 -0400 Received: from [199.232.76.173] (port=49043 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mz7xM-00015L-Rn for grub-devel@gnu.org; Sat, 17 Oct 2009 08:00:20 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:45934 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mz7xL-0001ix-KT for grub-devel@gnu.org; Sat, 17 Oct 2009 08:00:19 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1Mz7xG-0007bi-SH for grub-devel@gnu.org; Sat, 17 Oct 2009 14:00:15 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1Mz7xF-00013L-VA for grub-devel@gnu.org; Sat, 17 Oct 2009 14:00:13 +0200 Date: Sat, 17 Oct 2009 14:00:13 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091017120013.GA4040@thorin> References: <4AD87D15.7060408@gmail.com> <20091016160156.GA4986@nubol.oskuro.net> <20091016183805.GE7037@thorin> <4AD8D305.5000806@gmail.com> <20091016205258.GA8496@thorin> <4AD8E0CF.9080509@gmail.com> <20091016215343.GA9378@thorin> <4AD8F11D.1030007@gmail.com> <20091017112545.GA3556@thorin> <4AD9ADE9.3020004@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD9ADE9.3020004@gmail.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] Refuse to install on XFS destroying its superblock X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 17 Oct 2009 12:00:26 -0000 On Sat, Oct 17, 2009 at 01:43:37PM +0200, Vladimir 'phcoder' Serbinenko wrote: > Robert Millan wrote: > > On Sat, Oct 17, 2009 at 12:18:05AM +0200, Vladimir 'phcoder' Serbinenko wrote: > > > >> 2009-10-16 Vladimir Serbinenko > >> > >> + * util/i386/pc/grub-setup.c (setup): Refuse to overwrite XFS superblock. > >> + (options): New option --destroy-xfs. > >> + (main): Handle --destroy-xfs. > >> > > > > I gave this some more thought, and I think this could be less ad-hoc. We're > > treating XFS as if it were a "weird", unique thing just because it isn't biased > > towards DOS-style boot like most filesystems are. > > > > Instead, I've done something more generic, using our standard filesystem > > probing engine which should be more reliable than a single memcmp. > > > > > The danger is that fs_probe may reject filesystem as valid just because > it's newer than expected. What do you mean with "reject filesystem as valid"? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."