From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Horman <horms@verge.net.au>
Subject: Re: Possible bug with pass-through hot-plug?
Date: Mon, 19 Oct 2009 11:09:01 +0900
Message-ID: <20091019020901.GG11338@verge.net.au>
References: <20091012223616.GC9072@verge.net.au>
	<8686c3cd0910130208k7b9b0feva576864c9d819737@mail.gmail.com>
	<20091013094345.GA16712@verge.net.au>
	<8686c3cd0910130252m6a57388cv8b4d5211a14a4998@mail.gmail.com>
	<20091015093107.GA11293@verge.net.au>
	<8686c3cd0910150238h3d79d81dse8ee1ecb8f5350f2@mail.gmail.com>
	<20091015110632.GA14946@verge.net.au>
	<8686c3cd0910150702l542f75cbq6ffeee9c1ea47057@mail.gmail.com>
	<20091016074352.GA17063@verge.net.au>
	<8686c3cd0910172220k25ba4f13kdb1ca1c6854d6fdd@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <8686c3cd0910172220k25ba4f13kdb1ca1c6854d6fdd@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tom Rotenberg <tom.rotenberg@gmail.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi Tom,

On Sun, Oct 18, 2009 at 07:20:05AM +0200, Tom Rotenberg wrote:
> Simon,
> 
> Just checked what u propsed, and it works.

I must confess that I am surprised. Good work :-)

> So, i'm pretty sure, that the problem is with the ASL code. I thought
> of an implementaion change of the ASL code, which will make it work:
> we will change it from:
> ...
> if ( slt == 0x1 )
> else if (slt == 0x2)
> ...
> else if (slt == 0x20)
> .,..
> 
> to the following (just as an example):
> if ( slt < 0x10 )
> {
>     if (slt == 0x1)
> ...
> } else {
>     if ( slt == 0x11)
> ...
> }
> 
> What do u think about this?

I think that could be a good attack. To be honest I haven't done
that much work with ASL, so I'm not sure how easy it would be
to implement anything more sophisticated than what you suggest.

The ASL code that you're hacking on was auto generated (off-line, by me)
(unless I'm mistaken). Auto generating the replacement is probably
a good idea. I can take a stab at that if you like, though time is
quite tight at the moment as I'm travelling and in meetings a lot,
so it might have to wait a week or so.