Re: [PATCH] SetProperty method and Powered property missing from modem-api doc.

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1674 bytes --]

Hi Marko,

> SetProperty method and Powered Property where missing from modem-api.txt

I'm having trouble applying this patch.  Are you using a private repository by 
any chance?

git am --3way ~/merge/\[PATCH\]\ SetProperty\ method\ and\ Powered\ property\ 
missing\ from\ modem-api\ doc 
Applying: SetProperty method and Powered property missing from modem-api doc.
error: patch failed: doc/modem-api.txt:12
error: doc/modem-api.txt: patch does not apply
Using index info to reconstruct a base tree...
error: patch failed: doc/modem-api.txt:12
error: doc/modem-api.txt: patch does not apply
Did you hand edit your patch?
It does not apply to blobs recorded in its index.
Cannot fall back to three-way merge.
Patch failed at 0001 SetProperty method and Powered property missing from 
modem-api doc.
When you have resolved this problem run "git am -3 --resolved".
If you would prefer to skip this patch, instead run "git am -3 --skip".
To restore the original branch and stop patching run "git am -3 --abort".

>
> Question:
>
> I'm not sure if the "On success a PropertyChanged signal will be emitted."
> message is valid, as the PropertyChanged signal is sent only once when
> doing for example the following:

To be pedantic: a successful method invocation does mean that a 
PropertyChanged will be emitted.  PropertyChanged is emitted only when the 
property has actually changed.  Thus if the property is being set to its 
current value, oFono will not emit the signal (but return success to the 
caller)  However, the wording is probably OK since you generally set the 
property to something that is different.

Regards,
-Denis