From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 3/5] Nested VMX patch 3 implements vmptrld and vmptrst
Date: Mon, 19 Oct 2009 14:59:53 +0200
Message-ID: <20091019125953.GE29477@redhat.com>
References: <1255617706-13564-1-git-send-email-oritw@il.ibm.com>
 <1255617706-13564-2-git-send-email-oritw@il.ibm.com>
 <1255617706-13564-3-git-send-email-oritw@il.ibm.com>
 <1255617706-13564-4-git-send-email-oritw@il.ibm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org, benami@il.ibm.com, abelg@il.ibm.com,
	muli@il.ibm.com, aliguori@us.ibm.com, mdday@us.ibm.com
To: oritw@il.ibm.com
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:36614 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751389AbZJSM7y (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 19 Oct 2009 08:59:54 -0400
Content-Disposition: inline
In-Reply-To: <1255617706-13564-4-git-send-email-oritw@il.ibm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Oct 15, 2009 at 04:41:44PM +0200, oritw@il.ibm.com wrote:
> +static struct page *nested_get_page(struct kvm_vcpu *vcpu,
> +				    u64 vmcs_addr)
> +{
> +	struct page *vmcs_page = NULL;
> +
> +	down_read(&current->mm->mmap_sem);
> +	vmcs_page = gfn_to_page(vcpu->kvm, vmcs_addr >> PAGE_SHIFT);
> +	up_read(&current->mm->mmap_sem);
Why are you taking mmap_sem here? gup_fast() takes it if required.

> +
> +	if (is_error_page(vmcs_page)) {
> +		printk(KERN_ERR "%s error allocating page \n", __func__);
> +		kvm_release_page_clean(vmcs_page);
> +		return NULL;
> +	}
> +
> +	return vmcs_page;
> +
> +}
> +

--
			Gleb.