All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 04/13] Removed MSI capability in the pci-back driver.
Date: Mon, 19 Oct 2009 11:04:15 -0400	[thread overview]
Message-ID: <20091019150415.GB13322@phenom.dumpdata.com> (raw)
In-Reply-To: <4AD4F90C.2080204@goop.org>

On Tue, Oct 13, 2009 at 03:02:52PM -0700, Jeremy Fitzhardinge wrote:
> On 10/13/09 14:22, Konrad Rzeszutek Wilk wrote:
> > Currently the tree does not have the Xen MSI capability. Will re-introduce
> > when the capability exists.
> >   
> 
> Devices with MSI interrupts work fine in dom0.  Are you referring to
> something else?

The issue I was referring to was the ownership of MSI interrupts for PV guests.
Mainly the mechanism for binding an MSI interrupt to a guest is not part of the
Linux pv-ops kernel. If you look in the xen_setup_msi_irqs function, 

 624         map_irq.domid = domid;
 625         map_irq.type = MAP_PIRQ_TYPE_MSI;
 626         map_irq.index = -1;
 627         map_irq.pirq = -1;
 628         map_irq.bus = dev->bus->number;
 629         map_irq.devfn = dev->devfn;
 630 
.. snip ..
 649         rc = HYPERVISOR_physdev_op(PHYSDEVOP_map_pirq, &map_irq);

The domain that the vector is assigned to is the DOMID_SELF (domid earlier on
is set to that). For pciback purpose, this needs to be the guest domain id. 
HVM guests accomplish this in the hw/pt-msi.c code, so we need only to worry
about the PV case.

In the 2.6.18 code there was hook that would pass this domaid ID around
for the device (register_msi_get_owner and its friend). I am trying to figure out if
there is a more upstream-applicable way of doing this.

> 
>     J
> 

  reply	other threads:[~2009-10-19 15:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 21:22 [PATCH PV_OPS] pciback support Konrad Rzeszutek Wilk
2009-10-13 21:22 ` [PATCH 01/13] Initial copy from linux-2.6.18.hg off pciback driver Konrad Rzeszutek Wilk
2009-10-13 21:22   ` [PATCH 02/13] Including the pciif.h header file Konrad Rzeszutek Wilk
2009-10-13 21:22     ` [PATCH 03/13] Fix include header name change (evtchn.h is now events.h) Konrad Rzeszutek Wilk
2009-10-13 21:22       ` [PATCH 04/13] Removed MSI capability in the pci-back driver Konrad Rzeszutek Wilk
2009-10-13 21:22         ` [PATCH 05/13] Use pci_is_enabled() instead of is_enabled Konrad Rzeszutek Wilk
2009-10-13 21:22           ` [PATCH 06/13] Fix usage of INIT_WORK Konrad Rzeszutek Wilk
2009-10-13 21:22             ` [PATCH 07/13] Update the calling mechanism for xenbus_[map|unmap]_ring_valloc functions Konrad Rzeszutek Wilk
2009-10-13 21:22               ` [PATCH 08/13] Xen paravirtualised PCI hotplug Konrad Rzeszutek Wilk
2009-10-13 21:22                 ` [PATCH 09/13] xenbus: Add new states to xenbus_strstate() Konrad Rzeszutek Wilk
2009-10-13 21:22                   ` [PATCH 10/13] xenbus: prevent warnings on unhandled enumeration values Konrad Rzeszutek Wilk
2009-10-13 21:22                     ` [PATCH 11/13] pciback: Add check to load only under priviliged domain Konrad Rzeszutek Wilk
2009-10-13 21:22                       ` [PATCH 12/13] Remove usage of pci_restore_bars() as Linux handles the power-up states correctly now Konrad Rzeszutek Wilk
2009-10-13 21:22                         ` [PATCH 13/13] pciback: Enable Xen-PCI-back to be compiled Konrad Rzeszutek Wilk
2009-10-16 10:59                 ` [PATCH 08/13] Xen paravirtualised PCI hotplug Vincent Hanquez
2009-10-19 14:50                   ` Konrad Rzeszutek Wilk
2009-10-20  8:15                     ` Yosuke Iwamatsu
2009-10-13 22:02         ` [PATCH 04/13] Removed MSI capability in the pci-back driver Jeremy Fitzhardinge
2009-10-19 15:04           ` Konrad Rzeszutek Wilk [this message]
2009-10-13 22:38 ` [PATCH PV_OPS] pciback support Jeremy Fitzhardinge
2009-10-14 15:16   ` Konrad Rzeszutek Wilk
2009-10-14 16:17     ` Jeremy Fitzhardinge
2009-10-14 19:19 ` Sander Eikelenboom
2009-10-15 18:38   ` Konrad Rzeszutek Wilk
2009-10-15 19:49     ` Sander Eikelenboom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091019150415.GB13322@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=jeremy@goop.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.