From: Samuel Ortiz <sameo@linux.intel.com>
To: Paul Fertser <fercerpav@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Nelson Castillo <arhuaco@freaks-unidos.net>
Subject: Re: [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys
Date: Mon, 19 Oct 2009 17:38:17 +0200 [thread overview]
Message-ID: <20091019153816.GE3885@sortiz.org> (raw)
In-Reply-To: <1255471956-29201-1-git-send-email-fercerpav@gmail.com>
Hi Paul,
I applied all patches except patch 5, on which I commented about.
Also, patch 3 didnt have any changelog execpt the SOB lines. I expect to get
something even for such trivial patches.
Thanks for your work.
Cheers,
Samuel.
On Wed, Oct 14, 2009 at 02:12:30AM +0400, Paul Fertser wrote:
> On gta02 hardware revision A5 it can actually bring the system down
> during normal operating conditions so we disable it.
>
> Signed-off-by: Paul Fertser <fercerpav@gmail.com>
> ---
> drivers/mfd/pcf50633-core.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
> index d26d774..6efe5c3 100644
> --- a/drivers/mfd/pcf50633-core.c
> +++ b/drivers/mfd/pcf50633-core.c
> @@ -345,6 +345,9 @@ static void pcf50633_irq_worker(struct work_struct *work)
> goto out;
> }
>
> + /* defeat 8s death from lowsys on A5 */
> + pcf50633_reg_write(pcf, PCF50633_REG_OOCSHDWN, 0x04);
> +
> /* We immediately read the usb and adapter status. We thus make sure
> * only of USBINS/USBREM IRQ handlers are called */
> if (pcf_int[0] & (PCF50633_INT1_USBINS | PCF50633_INT1_USBREM)) {
> --
> 1.6.0.6
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2009-10-19 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 22:12 [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys Paul Fertser
2009-10-13 22:12 ` [PATCH 2/7] mfd: pcf50633: make suspend/resume belong to i2c_driver Paul Fertser
2009-10-13 22:12 ` [PATCH 3/7] mfd: pcf50633: move messages to appropriate log levels Paul Fertser
2009-10-13 22:12 ` [PATCH 4/7] mfd: pcf50633: Fix memleak in pcf50633_client_dev_register Paul Fertser
2009-10-13 22:12 ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Paul Fertser
2009-10-13 22:12 ` [PATCH 6/7] mfd: pcf50633: Use platform_device_add_data to set regulator platform data Paul Fertser
2009-10-13 22:12 ` [PATCH 7/7] mfd: pcf50633: Fix pcf50633-regulator drvdata usage Paul Fertser
2009-10-19 15:08 ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Samuel Ortiz
2009-10-19 23:09 ` Paul Fertser
2009-10-20 9:23 ` Samuel Ortiz
2009-10-19 15:38 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019153816.GE3885@sortiz.org \
--to=sameo@linux.intel.com \
--cc=arhuaco@freaks-unidos.net \
--cc=fercerpav@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.