Re: [PATCH 1/2] twl4030: Do not dereference null pointer in error path

[Samuel Ortiz <sameo@linux.intel.com>]

Hi Ilkka,

On Fri, Oct 16, 2009 at 04:21:41PM +0200, ilkka.koskinen@nokia.com wrote:
> 
> Hi Samuel,
> 
> What is the status of this patch and the other one:
> [PATCH 2/2] twl4030: Enable low-power mode to 32KHz oscillator
I'm sorry but it seems I havent received those 2 patches. Could you please
re-send them ?

Cheers,
Samuel.


> Cheers, Ilkka
> 
> >-----Original Message-----
> >From: Koskinen Ilkka (Nokia-D/Tampere) 
> >Sent: 30 September, 2009 18:12
> >To: linux-kernel@vger.kernel.org; sameo@linux.intel.com
> >Cc: linux-omap@vger.kernel.org; Koskinen Ilkka (Nokia-D/Tampere)
> >Subject: [PATCH 1/2] twl4030: Do not dereference null pointer 
> >in error path
> >
> >Signed-off-by: Ilkka Koskinen <ilkka.koskinen@nokia.com>
> >---
> > drivers/mfd/twl4030-core.c |    2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/twl4030-core.c b/drivers/mfd/twl4030-core.c
> >index e424cf6..8cf0a02 100644
> >--- a/drivers/mfd/twl4030-core.c
> >+++ b/drivers/mfd/twl4030-core.c
> >@@ -792,7 +792,7 @@ twl4030_probe(struct i2c_client *client, 
> >const struct i2c_device_id *id)
> > 			twl->client = i2c_new_dummy(client->adapter,
> > 					twl->address);
> > 			if (!twl->client) {
> >-				dev_err(&twl->client->dev,
> >+				dev_err(&client->dev,
> > 					"can't attach client %d\n", i);
> > 				status = -ENOMEM;
> > 				goto fail;
> >-- 
> >1.6.0.4
> >
> >

-- 
Intel Open Source Technology Centre
http://oss.intel.com/