From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Avi Kivity <avi@redhat.com>, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Fix guest single-stepping while interruptible
Date: Mon, 19 Oct 2009 16:52:39 -0200 [thread overview]
Message-ID: <20091019185239.GF14227@amt.cnet> (raw)
In-Reply-To: <4ADAFAFC.2010603@web.de>
On Sun, Oct 18, 2009 at 01:24:44PM +0200, Jan Kiszka wrote:
> Commit 705c5323 opened the doors of hell by unconditionally injecting
> single-step flags as long as guest_debug signaled this. This doesn't
> work when the guest branches into some interrupt or exception handler
> and triggers a vmexit with flag reloading.
>
> Fix it by saving cs:rip when user space requests single-stepping and
> restricting the trace flag injection to this guest code position.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> arch/x86/include/asm/kvm_host.h | 4 +++
> arch/x86/kvm/x86.c | 47 +++++++++++++++++++++++----------------
> 2 files changed, 32 insertions(+), 19 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2009-10-19 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-18 11:24 [PATCH] KVM: x86: Fix guest single-stepping while interruptible Jan Kiszka
2009-10-19 18:52 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091019185239.GF14227@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.