All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: "Hennerich, Michael" <Michael.Hennerich@analog.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	Mike Frysinger <vapier@gentoo.org>,
	Bryan Wu <cooloney@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: Staticise __adp5520_ack_bits()
Date: Tue, 20 Oct 2009 00:26:37 +0200	[thread overview]
Message-ID: <20091019222636.GA22300@sortiz.org> (raw)
In-Reply-To: <8A42379416420646B9BFAC9682273B6D0E695B8F@limkexm3.ad.analog.com>

On Mon, Oct 19, 2009 at 04:09:07PM +0100, Hennerich, Michael wrote:
> >From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> >The function is not exported as the __ indicates. __
> >
> >Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> 
> Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Thanks guys, applied to my for-next branch.

Cheers,
Samuel.
 
> 
> >---
> > drivers/mfd/adp5520.c |    3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> >diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> >index 401a9b6..b266447 100644
> >--- a/drivers/mfd/adp5520.c
> >+++ b/drivers/mfd/adp5520.c
> >@@ -66,7 +66,8 @@ static int __adp5520_write(struct i2c_client *client,
> > 	return 0;
> > }
> >
> >-int __adp5520_ack_bits(struct i2c_client *client, int reg, uint8_t
> bit_mask)
> >+static int __adp5520_ack_bits(struct i2c_client *client, int reg,
> >+			      uint8_t bit_mask)
> > {
> > 	struct adp5520_chip *chip = i2c_get_clientdata(client);
> > 	uint8_t reg_val;
> >--
> >1.6.5
> 
> -Michael

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

      reply	other threads:[~2009-10-19 22:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-19 14:46 [PATCH] mfd: Staticise __adp5520_ack_bits() Mark Brown
2009-10-19 15:09 ` Hennerich, Michael
2009-10-19 22:26   ` Samuel Ortiz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091019222636.GA22300@sortiz.org \
    --to=sameo@linux.intel.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=cooloney@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.