From: Alex Chiang <achiang@hp.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: shaohua.li@intel.com, lenb@kernel.org,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/6] ACPI: dock: convert sysfs attributes to an attribute_group
Date: Mon, 19 Oct 2009 20:57:33 -0600 [thread overview]
Message-ID: <20091020025733.GA5814@ldl.fc.hp.com> (raw)
In-Reply-To: <20091020013844.GB24370@core.coreip.homeip.net>
* Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> On Mon, Oct 19, 2009 at 03:14:24PM -0600, Alex Chiang wrote:
> > As suggested by Dmitry Torokhov, convert the individual sysfs
> > attributes into an attribute group.
> >
> > This change eliminates quite a bit of copy/paste code in the
> > error handling paths.
> >
>
> Looks good to me, thank you for making the changes.
Thank you for your patience along the way.
Can I count this as an Acked-by? :)
/ac
next prev parent reply other threads:[~2009-10-20 2:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 21:14 [PATCH v4 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-19 21:14 ` [PATCH v4 1/6] ACPI: dock: convert sysfs attributes to an attribute_group Alex Chiang
2009-10-20 1:38 ` Dmitry Torokhov
2009-10-20 2:57 ` Alex Chiang [this message]
2009-10-20 3:26 ` Dmitry Torokhov
2009-10-19 21:14 ` [PATCH v4 2/6] ACPI: dock: combine add|alloc_dock_dependent_device Alex Chiang
2009-10-19 21:14 ` [PATCH v4 3/6] ACPI: dock: remove global 'dock_device_name' Alex Chiang
2009-10-19 21:14 ` [PATCH v4 4/6] ACPI: dock: dock_add - hoist up platform_device_register_simple() Alex Chiang
2009-10-19 21:14 ` [PATCH v4 5/6] ACPI: dock: add struct dock_station * directly to platform device data Alex Chiang
2009-10-19 21:14 ` [PATCH v4 6/6] ACPI: dock: minor whitespace and style cleanups Alex Chiang
2009-10-29 0:07 ` [PATCH v4 0/6] ACPI: dock: code hygiene Alex Chiang
2009-10-29 1:00 ` Shaohua Li
2009-11-03 20:55 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020025733.GA5814@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.