From: Ben Dooks <ben@simtec.co.uk>
To: netdev@vger.kernel.org
Cc: Ping.Doong@Micrel.Com
Subject: [patch 3/3] KS8851: Fix ks8851_set_rx_mode() for IFF_MULTICAST
Date: Tue, 20 Oct 2009 10:49:05 +0100 [thread overview]
Message-ID: <20091020094954.578325358@fluff.org.uk> (raw)
In-Reply-To: 20091020094902.274646871@fluff.org.uk
[-- Attachment #1: ks8851-fix-mc-rxmode.patch --]
[-- Type: text/plain, Size: 1096 bytes --]
In ks8851_set_rx_mode() the case handling IFF_MULTICAST was also setting
the RXCR1_AE bit by accident. This meant that all unicast frames where
being accepted by the device. Remove RXCR1_AE from this case.
Note, RXCR1_AE was also masking a problem with setting the MAC address
properly, so needs to be applied after fixing the MAC write order.
Fixes a bug reported by Doong, Ping of Micrel. This version of the
patch avoids setting RXCR1_ME for all cases.
Signed-off-by: Ben Dooks <ben@simtec.co.uk>
---
drivers/net/ks8851.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: b/drivers/net/ks8851.c
===================================================================
--- a/drivers/net/ks8851.c 2009-10-13 13:28:50.000000000 +0100
+++ b/drivers/net/ks8851.c 2009-10-13 13:28:51.000000000 +0100
@@ -980,7 +980,7 @@ static void ks8851_set_rx_mode(struct ne
mcptr = mcptr->next;
}
- rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXAE | RXCR1_RXPAFMA;
+ rxctrl.rxcr1 = RXCR1_RXME | RXCR1_RXPAFMA;
} else {
/* just accept broadcast / unicast */
rxctrl.rxcr1 = RXCR1_RXPAFMA;
next prev parent reply other threads:[~2009-10-20 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 9:49 [patch 0/3] KS8851 updates for -rc5 Ben Dooks
2009-10-20 9:49 ` [patch 1/3] KS8851: Add soft reset at probe time Ben Dooks
2009-10-20 9:49 ` [patch 2/3] KS8851: Fix MAC address write order Ben Dooks
2009-10-20 9:49 ` Ben Dooks [this message]
2009-10-20 17:53 ` [patch 0/3] KS8851 updates for -rc5 Doong, Ping
2009-10-20 22:26 ` Ben Dooks
2009-10-21 2:11 ` David Miller
2009-10-21 2:12 ` David Miller
2009-10-21 10:44 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020094954.578325358@fluff.org.uk \
--to=ben@simtec.co.uk \
--cc=Ping.Doong@Micrel.Com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.