All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Carmelo Amoroso <carmelo73@gmail.com>
Cc: Greg KH <greg@kroah.com>,
	Alan Jenkins <sourcejedi.lkml@googlemail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-kbuild <linux-kbuild@vger.kernel.org>
Subject: Re: Fast LKM symbol resolution with SysV ELH hash table
Date: Tue, 20 Oct 2009 11:26:25 +1030	[thread overview]
Message-ID: <200910201126.26110.rusty@rustcorp.com.au> (raw)
In-Reply-To: <2ccd6e3c0910190802w117f8ac1nb562214786904c04@mail.gmail.com>

On Tue, 20 Oct 2009 01:32:51 am Carmelo Amoroso wrote:
> 2009/10/19 Greg KH <greg@kroah.com>:
> > On Mon, Oct 19, 2009 at 01:45:20PM +0200, Carmelo Amoroso wrote:
> >> Just a few other notes. The current implementation I did based on SysV
> >> has a drawback that is not backward compatible, so you cannot use old
> >> modules with a kernel with the option enabled due to changes on struct
> >> kernel_symbol.
> >
> > Why would this be a problem?  Whenever making a kernel config change,
> > you should be able to rebuild everything, as lots of other configuration
> > options are that way.
> 
> This is not always true... there could be cases in which you cannot
> recompile old modules
> (e.g vendors that provide non GPL modules)

And breaking them is a feature.  I do not go out of my way to avoid breaking
out-of-tree modules; it's certainly more important to have simple maintainable
code.

You guys figure out what the best speed/size tradeoff is, and send me the
patch for review.

Thanks!
Rusty.

  parent reply	other threads:[~2009-10-20  0:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-18  8:09 Fast LKM symbol resolution with SysV ELH hash table Carmelo Amoroso
2009-10-18 12:44 ` Alan Jenkins
2009-10-18 16:43   ` Alan Jenkins
2009-10-18 21:47   ` Greg KH
2009-10-19  0:01     ` Alan Jenkins
2009-10-19 11:45     ` Carmelo Amoroso
2009-10-19 13:22       ` Greg KH
2009-10-19 15:02         ` Carmelo Amoroso
2009-10-19 19:10           ` Greg KH
2009-10-19 20:46             ` Alan Jenkins
2009-10-20  0:56           ` Rusty Russell [this message]
2009-10-21  5:43           ` Robert Hancock
2009-10-21 13:48             ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910201126.26110.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=carmelo73@gmail.com \
    --cc=greg@kroah.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sourcejedi.lkml@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.