From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N0Des-00067j-58 for qemu-devel@nongnu.org; Tue, 20 Oct 2009 08:17:46 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N0Den-00066F-9z for qemu-devel@nongnu.org; Tue, 20 Oct 2009 08:17:45 -0400 Received: from [199.232.76.173] (port=43922 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N0Dem-000660-C2 for qemu-devel@nongnu.org; Tue, 20 Oct 2009 08:17:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34372) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N0Dem-00012M-0f for qemu-devel@nongnu.org; Tue, 20 Oct 2009 08:17:40 -0400 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9KCHdBY026280 for ; Tue, 20 Oct 2009 08:17:39 -0400 Date: Tue, 20 Oct 2009 17:46:59 +0530 From: Amit Shah Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Message-ID: <20091020121659.GD5487@amit-x200.redhat.com> References: <1256022825-16180-1-git-send-email-amit.shah@redhat.com> <1256022825-16180-2-git-send-email-amit.shah@redhat.com> <1256022825-16180-3-git-send-email-amit.shah@redhat.com> <20091020110806.GA12094@amd.home.annexia.org> <20091020120123.GA5487@amit-x200.redhat.com> <20091020120559.GA24800@amd.home.annexia.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091020120559.GA24800@amd.home.annexia.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org On (Tue) Oct 20 2009 [13:05:59], Richard W.M. Jones wrote: > On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote: > > How about (deprecated)? (We need to have this in some general policy of > > deprecating command-line options.) > > No, the important thing is that we can detect somehow that multiport > virtio console is possible for some random version of qemu that we > have to work with. > > The only feasible way we've been able to discover is to poke qemu with > various arguments (usually, "qemu -help") and then match on substrings > in the output. Hm, probing with -device '?' will get you the new devices: -device virtio-serial-pci and -device virtserialport are two new devices added (along with -device virtconsole). > If there's a better way to do this, please let me know. I'm not sure of that, but there should be. > But for now, having "(multiport)" there allows us to detect that > multiport virtio console is supported. But suggesting -virtioconsole supports multiport is misleading and further usage of -virtioconsole is not to be encouraged as well.. > > > I think you mean -device virtconsole here. > > > > Yeah; thanks. Will fix. > > So is this documentation correct or not? > > http://www.linux-kvm.org/page/VMchannel_Requirements#Invocation Yes, that's updated very recently and is according to what we have now. Amit