From: Matt Kraai <kraai@ftbfs.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: set PERL_PATH and SHELL_PATH unconditionally
Date: Tue, 20 Oct 2009 09:33:07 -0700 [thread overview]
Message-ID: <20091020163307.GA5208@ftbfs.org> (raw)
In-Reply-To: <7vtyxuox7u.fsf@alter.siamese.dyndns.org>
On Tue, Oct 20, 2009 at 09:18:29AM -0700, Junio C Hamano wrote:
> Matt Kraai <kraai@ftbfs.org> writes:
>
> > Do not check whether PERL_PATH and SHELL_PATH are undefined before
> > setting their default values. This prevents them from being set via
> > environment variables.
>
> Is there an upside of "preventing them from getting set", by the way?
Not that I know of.
I originally thought that the checks were superfluous, but now I just
believe they're inconsistent and confusing to people like me who think
they understand Makefiles but don't. :)
--
Matt Kraai http://ftbfs.org/
prev parent reply other threads:[~2009-10-20 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 3:50 Extra checks for PERL_PATH and SHELL_PATH? Matt Kraai
2009-10-20 6:36 ` Junio C Hamano
2009-10-20 9:06 ` [PATCH] Makefile: set PERL_PATH and SHELL_PATH unconditionally Matt Kraai
2009-10-20 16:18 ` Junio C Hamano
2009-10-20 16:33 ` Matt Kraai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020163307.GA5208@ftbfs.org \
--to=kraai@ftbfs.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.