From: "Michael S. Tsirkin" <mst@redhat.com>
To: Chris Wright <chrisw@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Dor Laor <dlaor@redhat.com>,
kvm@vger.kernel.org
Subject: qemu-kvm: require 4K aligned resource size for memory
Date: Tue, 20 Oct 2009 19:15:09 +0200 [thread overview]
Message-ID: <20091020171508.GD13378@redhat.com> (raw)
KVM does not virtualize low address bits for memory accesses, so we must
require that PCI BAR size is a multiple of 4K for passthrough to work
(this also guarantees that address is 4K aligned).
Users of recent linux kernels can force resource size up to 4K
using:
commit 32a9a682bef2f6fce7026bd94d1ce20028b0e52d
Author: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
Date: Mon Mar 16 17:13:39 2009 +0900
PCI: allow assignment of memory resources with a specified alignment
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
diff --git a/hw/device-assignment.c b/hw/device-assignment.c
index 237060f..c2ef31f 100644
--- a/hw/device-assignment.c
+++ b/hw/device-assignment.c
@@ -381,6 +381,14 @@ static int assigned_dev_register_regions(PCIRegion *io_regions,
int t = cur_region->type & IORESOURCE_PREFETCH
? PCI_ADDRESS_SPACE_MEM_PREFETCH
: PCI_ADDRESS_SPACE_MEM;
+ if (cur_region->size & 0xFFF) {
+ fprintf(stderr, "Unable to assign device: PCI region %d "
+ "at address 0x%llx has size 0x%x, "
+ " which is not a multiple of 4K\n",
+ i, (unsigned long long)cur_region->base_addr,
+ cur_region->size);
+ return -1;
+ }
/* map physical memory */
pci_dev->v_addrs[i].e_physbase = cur_region->base_addr;
next reply other threads:[~2009-10-20 17:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 17:15 Michael S. Tsirkin [this message]
2009-10-22 6:42 ` qemu-kvm: require 4K aligned resource size for memory Chris Wright
2009-10-22 9:18 ` Michael S. Tsirkin
2009-10-22 16:37 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091020171508.GD13378@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=chrisw@redhat.com \
--cc=dlaor@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.