* [PATCH] multipath-tools: Fix dry runs to identify renames
@ 2009-10-20 19:50 Benjamin Marzinski
2009-10-20 20:47 ` Christophe Varoqui
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Marzinski @ 2009-10-20 19:50 UTC (permalink / raw)
To: device-mapper development
multipath didn't correctly identify renames on a dry run. This fixes it.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
---
libmultipath/configure.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: multipath-tools-091013/libmultipath/configure.c
===================================================================
--- multipath-tools-091013.orig/libmultipath/configure.c
+++ multipath-tools-091013/libmultipath/configure.c
@@ -151,7 +151,7 @@ select_action (struct multipath * mpp, v
if (!cmpp) {
cmpp = find_mp_by_wwid(curmp, mpp->wwid);
- if (cmpp && !conf->dry_run) {
+ if (cmpp) {
condlog(2, "%s: rename %s to %s", mpp->wwid,
cmpp->alias, mpp->alias);
strncpy(mpp->alias_old, cmpp->alias, WWID_SIZE);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] multipath-tools: Fix dry runs to identify renames
2009-10-20 19:50 [PATCH] multipath-tools: Fix dry runs to identify renames Benjamin Marzinski
@ 2009-10-20 20:47 ` Christophe Varoqui
0 siblings, 0 replies; 2+ messages in thread
From: Christophe Varoqui @ 2009-10-20 20:47 UTC (permalink / raw)
To: device-mapper development
Hi Ben,
this one was already in (sep 28th).
The 3 others are now merged.
Thanks.
On mar., 2009-10-20 at 14:50 -0500, Benjamin Marzinski wrote:
> multipath didn't correctly identify renames on a dry run. This fixes it.
>
> Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
> ---
> libmultipath/configure.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: multipath-tools-091013/libmultipath/configure.c
> ===================================================================
> --- multipath-tools-091013.orig/libmultipath/configure.c
> +++ multipath-tools-091013/libmultipath/configure.c
> @@ -151,7 +151,7 @@ select_action (struct multipath * mpp, v
> if (!cmpp) {
> cmpp = find_mp_by_wwid(curmp, mpp->wwid);
>
> - if (cmpp && !conf->dry_run) {
> + if (cmpp) {
> condlog(2, "%s: rename %s to %s", mpp->wwid,
> cmpp->alias, mpp->alias);
> strncpy(mpp->alias_old, cmpp->alias, WWID_SIZE);
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-20 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-20 19:50 [PATCH] multipath-tools: Fix dry runs to identify renames Benjamin Marzinski
2009-10-20 20:47 ` Christophe Varoqui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.