All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] ppc4xx: Update flash size in reg property of the NOR flash node
Date: Wed, 21 Oct 2009 11:05:09 +0200	[thread overview]
Message-ID: <200910211105.10055.sr@denx.de> (raw)
In-Reply-To: <20091020211247.DBCB91A00B@gemini.denx.de>

Hi Wolfgang,

On Tuesday 20 October 2009 23:12:47 Wolfgang Denk wrote:
> > Till now only the ranges in the ebc node are updated with the values
> > currently configured in the PPC4xx EBC controller. With this patch now
> > the NOR flash size is updated in the device tree blob as well. This is
> > done by scanning the compatible nodes "cfi-flash" and "jedec-flash"
> > for the correct chip select number.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Wolfgang Denk <wd@denx.de>
> > ---
> > Changes in v2:
> > - NOR flash nodes are now scanned/detected via the compatible node.
> 
> Thanks.
> 
> Hm... thinking about it, this problem most probably affects other
> (non-4xx boards as well). I guess there is no easy way to generalize
> this code enough tomake it usable by other (or even all?) boards as
> well?

I see no way to easily fix the NOR flash "reg" property for all non-4xx boards 
as well. But what I can do is, move the fdt_update_nor_flash_node() function 
into some common code (commond/fdt_support.c). This way it could be used by 
other boards/platforms as well.

Should I send an updated patch for this?

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2009-10-21  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 14:28 [U-Boot] [PATCH v2] ppc4xx: Update flash size in reg property of the NOR flash node Stefan Roese
2009-10-20 21:12 ` Wolfgang Denk
2009-10-21  9:05   ` Stefan Roese [this message]
2009-10-21  9:44     ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200910211105.10055.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.