From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-fx0-f221.google.com (mail-fx0-f221.google.com [209.85.220.221]) by ozlabs.org (Postfix) with ESMTP id 71E42B7BA3 for ; Thu, 22 Oct 2009 08:21:44 +1100 (EST) Received: by fxm21 with SMTP id 21so8101174fxm.9 for ; Wed, 21 Oct 2009 14:21:42 -0700 (PDT) Date: Wed, 21 Oct 2009 23:21:38 +0200 From: Frederic Weisbecker To: John Kacur Subject: Re: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd Message-ID: <20091021212137.GB4880@nowhere> References: <20091010153314.827301943@linutronix.de> <20091010153349.966159859@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Cc: Arnd Bergmann , Jonathan Corbet , LKML , linuxppc-dev@ozlabs.org, Thomas Gleixner , Ingo Molnar , Alan Cox List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Oct 21, 2009 at 11:07:18PM +0200, John Kacur wrote: > From 0c2b412cdccf73bdeb19bb866bfe556942eaeca2 Mon Sep 17 00:00:00 2001 > From: John Kacur > Date: Wed, 21 Oct 2009 23:01:12 +0200 > Subject: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd > > Now that we've removed the BKL here, let's explicitly set lleek to no_llseek > > Signed-off-by: John Kacur > --- > drivers/macintosh/ans-lcd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c > index 4ae8ec9..a1a1bde 100644 > --- a/drivers/macintosh/ans-lcd.c > +++ b/drivers/macintosh/ans-lcd.c > @@ -137,6 +137,7 @@ const struct file_operations anslcd_fops = { > .write = anslcd_write, > .unlocked_ioctl = anslcd_ioctl, > .open = anslcd_open, > + .llseedk = no_llseek, llseedk? :) Should we better pushdown default_llseek to every to every file operations that don't implement llseek? I don't know how many of them don't implement llseek() though. That said we can't continue anymore with this default attribution of default_llseek() on new fops. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755510AbZJUVVk (ORCPT ); Wed, 21 Oct 2009 17:21:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754684AbZJUVVj (ORCPT ); Wed, 21 Oct 2009 17:21:39 -0400 Received: from mail-fx0-f218.google.com ([209.85.220.218]:43526 "EHLO mail-fx0-f218.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754800AbZJUVVi (ORCPT ); Wed, 21 Oct 2009 17:21:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=YeN/khm5XqAFHK6U+1f5Nhk0N3K8expoyHMmRY0cOMUmIVVtCtnbwaV/ImzhyY3UPJ iwBqQofCVhGGZFQFwGtpcYsqQlbOkUB5I3vJ3vch7cz99BdXgwbNNY4Qhjh7+0XohN94 RfMYcO3kb8HPc0WIHpezuj2tWL2JW9TRG0Yrw= Date: Wed, 21 Oct 2009 23:21:38 +0200 From: Frederic Weisbecker To: John Kacur Cc: Thomas Gleixner , LKML , Ingo Molnar , Jonathan Corbet , Benjamin Herrenschmidt , linuxppc-dev@ozlabs.org, Alan Cox , Arnd Bergmann Subject: Re: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd Message-ID: <20091021212137.GB4880@nowhere> References: <20091010153314.827301943@linutronix.de> <20091010153349.966159859@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 21, 2009 at 11:07:18PM +0200, John Kacur wrote: > From 0c2b412cdccf73bdeb19bb866bfe556942eaeca2 Mon Sep 17 00:00:00 2001 > From: John Kacur > Date: Wed, 21 Oct 2009 23:01:12 +0200 > Subject: [PATCH] macintosh: Explicitly set llseek to no_llseek in ans-lcd > > Now that we've removed the BKL here, let's explicitly set lleek to no_llseek > > Signed-off-by: John Kacur > --- > drivers/macintosh/ans-lcd.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/macintosh/ans-lcd.c b/drivers/macintosh/ans-lcd.c > index 4ae8ec9..a1a1bde 100644 > --- a/drivers/macintosh/ans-lcd.c > +++ b/drivers/macintosh/ans-lcd.c > @@ -137,6 +137,7 @@ const struct file_operations anslcd_fops = { > .write = anslcd_write, > .unlocked_ioctl = anslcd_ioctl, > .open = anslcd_open, > + .llseedk = no_llseek, llseedk? :) Should we better pushdown default_llseek to every to every file operations that don't implement llseek? I don't know how many of them don't implement llseek() though. That said we can't continue anymore with this default attribution of default_llseek() on new fops.