All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Ortiz <sameo@linux.intel.com>
To: Ilkka Koskinen <ilkka.koskinen@nokia.com>
Cc: linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [Resend PATCH 2/2] twl4030: Enable low-power mode to 32kHz oscillator
Date: Thu, 22 Oct 2009 00:17:19 +0200	[thread overview]
Message-ID: <20091021221718.GB17796@sortiz.org> (raw)
In-Reply-To: <1256044973-14548-2-git-send-email-ilkka.koskinen@nokia.com>

Hi Ilkka,

On Tue, Oct 20, 2009 at 04:22:53PM +0300, Ilkka Koskinen wrote:
> +struct twl4030_clock_init_data {
> +	int ck32k_lowpwr_enable;
I guess you could use a bool here ?

Cheers,
Samuel.


> +};
> +
>  struct twl4030_bci_platform_data {
>  	int *battery_tmp_tbl;
>  	unsigned int tblsize;
> @@ -403,6 +407,7 @@ extern void twl4030_power_init(struct twl4030_power_data *triton2_scripts);
>  
>  struct twl4030_platform_data {
>  	unsigned				irq_base, irq_end;
> +	struct twl4030_clock_init_data		*clock;
>  	struct twl4030_bci_platform_data	*bci;
>  	struct twl4030_gpio_platform_data	*gpio;
>  	struct twl4030_madc_platform_data	*madc;
> -- 
> 1.6.0.4
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/

  reply	other threads:[~2009-10-21 22:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20 13:22 [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path Ilkka Koskinen
2009-10-20 13:22 ` [Resend PATCH 2/2] twl4030: Enable low-power mode to 32kHz oscillator Ilkka Koskinen
2009-10-21 22:17   ` Samuel Ortiz [this message]
2009-10-22 11:05     ` Ilkka Koskinen
2009-10-21 22:22 ` [Resend PATCH 1/2] twl4030: Do not dereference null pointer in error path Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091021221718.GB17796@sortiz.org \
    --to=sameo@linux.intel.com \
    --cc=ilkka.koskinen@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.