From: Alex Chiang <achiang@hp.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/5] mm: refactor unregister_cpu_under_node()
Date: Wed, 21 Oct 2009 22:15:20 -0600 [thread overview]
Message-ID: <20091022041520.15705.206.stgit@bob.kio> (raw)
In-Reply-To: <20091022040814.15705.95572.stgit@bob.kio>
By returning early if the node is not online, we can unindent the
interesting code by two levels.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/base/node.c | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index ef7dd22..ffda067 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -243,12 +243,18 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
{
- if (node_online(nid)) {
- struct sys_device *obj = get_cpu_sysdev(cpu);
- if (obj)
- sysfs_remove_link(&node_devices[nid].sysdev.kobj,
- kobject_name(&obj->kobj));
- }
+ struct sys_device *obj;
+
+ if (!node_online(nid))
+ return 0;
+
+ obj = get_cpu_sysdev(cpu);
+ if (!obj)
+ return 0;
+
+ sysfs_remove_link(&node_devices[nid].sysdev.kobj,
+ kobject_name(&obj->kobj));
+
return 0;
}
WARNING: multiple messages have this Message-ID (diff)
From: Alex Chiang <achiang@hp.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 3/5] mm: refactor unregister_cpu_under_node()
Date: Wed, 21 Oct 2009 22:15:20 -0600 [thread overview]
Message-ID: <20091022041520.15705.206.stgit@bob.kio> (raw)
In-Reply-To: <20091022040814.15705.95572.stgit@bob.kio>
By returning early if the node is not online, we can unindent the
interesting code by two levels.
No functional change.
Signed-off-by: Alex Chiang <achiang@hp.com>
---
drivers/base/node.c | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/drivers/base/node.c b/drivers/base/node.c
index ef7dd22..ffda067 100644
--- a/drivers/base/node.c
+++ b/drivers/base/node.c
@@ -243,12 +243,18 @@ int register_cpu_under_node(unsigned int cpu, unsigned int nid)
int unregister_cpu_under_node(unsigned int cpu, unsigned int nid)
{
- if (node_online(nid)) {
- struct sys_device *obj = get_cpu_sysdev(cpu);
- if (obj)
- sysfs_remove_link(&node_devices[nid].sysdev.kobj,
- kobject_name(&obj->kobj));
- }
+ struct sys_device *obj;
+
+ if (!node_online(nid))
+ return 0;
+
+ obj = get_cpu_sysdev(cpu);
+ if (!obj)
+ return 0;
+
+ sysfs_remove_link(&node_devices[nid].sysdev.kobj,
+ kobject_name(&obj->kobj));
+
return 0;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-10-22 4:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 4:15 [PATCH v2 0/5] mm: modest useability enhancements for node sysfs attrs Alex Chiang
2009-10-22 4:15 ` Alex Chiang
2009-10-22 4:15 ` [PATCH v2 1/5] mm: add numa node symlink for memory section in sysfs Alex Chiang
2009-10-22 4:15 ` Alex Chiang
2009-10-22 19:51 ` David Rientjes
2009-10-22 19:51 ` David Rientjes
2009-10-27 19:59 ` Alex Chiang
2009-10-27 19:59 ` Alex Chiang
2009-10-27 21:27 ` David Rientjes
2009-10-27 21:27 ` David Rientjes
2009-10-28 8:31 ` Heiko Carstens
2009-10-28 8:31 ` Heiko Carstens
2009-10-28 9:03 ` David Rientjes
2009-10-28 9:03 ` David Rientjes
2009-10-28 17:15 ` Alex Chiang
2009-10-28 17:15 ` Alex Chiang
2009-10-28 18:39 ` Alex Chiang
2009-10-28 18:39 ` Alex Chiang
2009-10-28 20:43 ` [patch -mm] mm: slab allocate memory section nodemask for large systems David Rientjes
2009-10-28 20:43 ` David Rientjes
2009-11-02 20:47 ` Alex Chiang
2009-11-02 20:47 ` Alex Chiang
2009-11-04 2:00 ` David Rientjes
2009-11-04 2:00 ` David Rientjes
2009-11-10 20:51 ` Andrew Morton
2009-11-10 20:51 ` Andrew Morton
2009-11-10 20:55 ` David Rientjes
2009-11-10 20:55 ` David Rientjes
2009-11-10 21:26 ` Alex Chiang
2009-11-10 21:26 ` Alex Chiang
2009-11-10 21:38 ` Andrew Morton
2009-11-10 21:38 ` Andrew Morton
2009-10-22 4:15 ` [PATCH v2 2/5] mm: refactor register_cpu_under_node() Alex Chiang
2009-10-22 4:15 ` Alex Chiang
2009-10-22 4:15 ` Alex Chiang [this message]
2009-10-22 4:15 ` [PATCH v2 3/5] mm: refactor unregister_cpu_under_node() Alex Chiang
2009-10-22 4:15 ` [PATCH v2 4/5] mm: add numa node symlink for cpu devices in sysfs Alex Chiang
2009-10-22 4:15 ` Alex Chiang
2009-10-22 19:52 ` David Rientjes
2009-10-22 19:52 ` David Rientjes
2009-10-22 4:15 ` [PATCH v2 5/5] Documentation: ABI: /sys/devices/system/cpu/cpu#/node Alex Chiang
2009-10-22 4:15 ` Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022041520.15705.206.stgit@bob.kio \
--to=achiang@hp.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.