From: Holger Schurig <hs4233@mail.mn-solutions.de>
To: Dan Williams <dcbw@redhat.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
John Linville <linville@tuxdriver.com>
Subject: Re: [PATCH] libertas: remove handling for CMD_802_11_LED_GPIO_CTRL
Date: Thu, 22 Oct 2009 09:53:17 +0200 [thread overview]
Message-ID: <200910220953.17995.hs4233@mail.mn-solutions.de> (raw)
In-Reply-To: <1256149730.5010.39.camel@localhost.localdomain>
> It's actually used by the OLPC folks; but right now there's
> simply no mechanism to configure that ability via WEXT. Is
> there some way to do this via the kernel LED framework instead
> that libertas should be using?
They use it?
No one did bother to send a patch for the in-kernel Libertas
driver during the last year. Sigh.
Also, if they use it, they need a patch on top of what is now in
the kernel, because the current in-kernel libertas driver has no
code to issue the CMD_802_11_LED_GPIO_CTRL. That's why I removed
it in the first place.
It's O.K. for me to keep this code in (it doesn't harm), but a
better approach would be
a) use a new-style commands, a.k.a. lbs_cmd_with_response()
b) use the in-kernel LED support (as you said)
--
http://www.holgerschurig.de
next prev parent reply other threads:[~2009-10-22 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-19 11:31 [PATCH] libertas: remove handling for CMD_802_11_LED_GPIO_CTRL Holger Schurig
2009-10-21 18:28 ` Dan Williams
2009-10-22 7:53 ` Holger Schurig [this message]
2009-10-23 15:45 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200910220953.17995.hs4233@mail.mn-solutions.de \
--to=hs4233@mail.mn-solutions.de \
--cc=dcbw@redhat.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.