Re: KVM: VMX: remove GUEST_CR3 write from vmx_vcpu_run

[Sheng Yang <sheng@linux.intel.com>]

On Tuesday 20 October 2009 20:37:20 Marcelo Tosatti wrote:
> GUEST_CR3 is updated via kvm_set_cr3 whenever CR3 value
> changes.

The description is not that accuracy... If CR3 value change in guest when EPT 
enabled, no VM Exit would happen, then no kvm_set_cr3...

-- 
regards
Yang, Sheng

>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
> index 364263a..325075f 100644
> --- a/arch/x86/kvm/vmx.c
> +++ b/arch/x86/kvm/vmx.c
> @@ -3638,10 +3638,9 @@ static void vmx_vcpu_run(struct kvm_vcpu *vcpu)
>  {
>  	struct vcpu_vmx *vmx = to_vmx(vcpu);
>
> -	if (enable_ept && is_paging(vcpu)) {
> -		vmcs_writel(GUEST_CR3, vcpu->arch.cr3);
> +	if (enable_ept && is_paging(vcpu))
>  		ept_load_pdptrs(vcpu);
> -	}
> +
>  	/* Record the guest's net vcpu time for enforced NMI injections. */
>  	if (unlikely(!cpu_has_virtual_nmis() && vmx->soft_vnmi_blocked))
>  		vmx->entry_time = ktime_get();
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html