From: Marcelo Tosatti <mtosatti@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, xma@us.ibm.com
Subject: Re: [PATCH] virtio-pci: fix per-vq MSI-X request logic
Date: Thu, 22 Oct 2009 14:17:18 -0200 [thread overview]
Message-ID: <20091022161718.GA3876@amt.cnet> (raw)
In-Reply-To: <20091022130606.GA6923@redhat.com>
On Thu, Oct 22, 2009 at 03:06:06PM +0200, Michael S. Tsirkin wrote:
> Commit f68d24082e22ccee3077d11aeb6dc5354f0ca7f1
> in 2.6.32-rc1 broke requesting IRQs for per-VQ MSI-X vectors:
> - vector number was used instead of the vector itself
> - we try to request an IRQ for VQ which does not
> have a callback handler
>
> This is a regression that causes warnings in kernel log,
> potentially lower performance as we need to scan vq list,
> and might cause system failure if the interrupt
> requested is in fact needed by another system.
>
> This was not noticed earlier because in most cases
> we were falling back on shared interrupt for all vqs.
Works for me. Thanks Michael.
Tested-by: Marcelo Tosatti <mtosatti@redhat.com>
next prev parent reply other threads:[~2009-10-22 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-22 13:06 [PATCH] virtio-pci: fix per-vq MSI-X request logic Michael S. Tsirkin
2009-10-22 16:17 ` Marcelo Tosatti [this message]
2009-10-22 16:17 ` Marcelo Tosatti
2009-10-23 11:08 ` Michael S. Tsirkin
2009-10-23 11:08 ` Michael S. Tsirkin
-- strict thread matches above, loose matches on Subject: below --
2009-10-22 13:06 Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091022161718.GA3876@amt.cnet \
--to=mtosatti@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
--cc=xma@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.