From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Serge E. Hallyn" Subject: Re: [PATCH] epoll: Check for fdtable races Date: Fri, 23 Oct 2009 22:19:50 -0500 Message-ID: <20091024031950.GB17294@us.ibm.com> References: <1256321658-15646-1-git-send-email-matthltc@us.ibm.com> <4AE25253.4040100@librato.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4AE25253.4040100-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Oren Laadan Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: containers.vger.kernel.org Quoting Oren Laadan (orenl-RdfvBDnrOixBDgjK7y7TUQ@public.gmane.org): > > > Matt Helsley wrote: > > In case it's possible to race with other tasks sharing the fdtable, > > check for NULL file * and exit with an error. > > > > Please consider merging this with the first patch in the series > > of epoll patches posted recently. > > > > Reported-by: "Serge E. Hallyn" > > Signed-off-by: Matt Helsley > > Cc: "Serge E. Hallyn" > > Already did that when I pulled your patch. > > BTW, I chose -EBUSY instead to tell the user to try again > later... when he/she isn't malicious anymore :) "Go stand in the corner and don't come out until you'll be NICE to your brother!" -serge