From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1N1qB6-00060f-Ud for mharc-grub-devel@gnu.org; Sat, 24 Oct 2009 19:37:44 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N1qB4-00060S-D2 for grub-devel@gnu.org; Sat, 24 Oct 2009 19:37:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N1qB0-000600-0h for grub-devel@gnu.org; Sat, 24 Oct 2009 19:37:41 -0400 Received: from [199.232.76.173] (port=34979 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N1qAz-0005zx-RZ for grub-devel@gnu.org; Sat, 24 Oct 2009 19:37:37 -0400 Received: from xvm-190-8.ghst.net ([217.70.190.8]:43016 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N1qAz-0006YJ-Er for grub-devel@gnu.org; Sat, 24 Oct 2009 19:37:37 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1N1qAw-0002GC-9W; Sun, 25 Oct 2009 01:37:34 +0200 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1N1qAv-0004yV-Nd; Sun, 25 Oct 2009 01:37:33 +0200 Date: Sun, 25 Oct 2009 01:37:33 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20091024233733.GB18233@thorin> References: <4AD9B5F0.40304@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4AD9B5F0.40304@parallels.com> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Cc: phcoder@gmail.com Subject: Re: [patch] deadloop in grub_ext2_iterate_dir X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2009 23:37:43 -0000 On Sat, Oct 17, 2009 at 04:17:52PM +0400, Vasily Averin wrote: > fix for deadloop in grub_ext2_iterate_dir: > fpos is not updated if dirent.direntlen == 0 Committed, thanks. On Sat, Oct 17, 2009 at 02:54:24PM +0200, Felix Zielcke wrote: > For consistency we should either always use the grub_Xe_to_cpuYZ > functions or never when checking for a 0 value. I've set it to keep not using it. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."