From: Pavel Machek <pavel@ucw.cz>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Linux Kernel Developers List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ext2: Avoid WARN() messages when failing to write to the superblock
Date: Sun, 25 Oct 2009 07:21:28 +0100 [thread overview]
Message-ID: <20091025062128.GA1391@ucw.cz> (raw)
In-Reply-To: <1256016146-2677-1-git-send-email-tytso@mit.edu>
On Tue 2009-10-20 01:22:26, Theodore Ts'o wrote:
> This fixes a common warning reported by kerneloops.org
>
> +static void ext2_clear_super_error(struct super_block * sb)
> +{
> + struct buffer_head *sbh = EXT2_SB(sb)->s_sbh;
> +
> + if (buffer_write_io_error(sbh)) {
> + /*
> + * Oh, dear. A previous attempt to write the
> + * superblock failed. This could happen because the
> + * USB device was yanked out. Or it could happen to
> + * be a transient write error and maybe the block will
> + * be remapped. Nothing we can do but to retry the
> + * write and hope for the best.
> + */
> + printk(KERN_ERR "EXT2-fs: %s previous I/O error to "
> + "superblock detected", sb->s_id);
KERN_ALERT/KERN_CRITICAL?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2009-10-25 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 5:22 [PATCH] ext2: Avoid WARN() messages when failing to write to the superblock Theodore Ts'o
2009-10-25 6:21 ` Pavel Machek [this message]
2009-10-26 4:08 ` Theodore Tso
2009-10-26 7:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091025062128.GA1391@ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.