From: Christoph Hellwig <hch@lst.de>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/3] ocfs2: Make ACLs always compiled into the kernel
Date: Sun, 25 Oct 2009 08:20:04 +0100 [thread overview]
Message-ID: <20091025072004.GB17121@lst.de> (raw)
In-Reply-To: <20091015134200.GD5971@duck.suse.cz>
On Thu, Oct 15, 2009 at 03:42:00PM +0200, Jan Kara wrote:
> > > -#ifdef CONFIG_OCFS2_FS_POSIX_ACL
> > > if (opts & OCFS2_MOUNT_POSIX_ACL)
> > > seq_printf(s, ",acl");
> > > else
> > > seq_printf(s, ",noacl");
> > > -#endif
> >
> > It might be a good idea to always print acl here for backwards
> > compatiblity.
> I don't understand here - why would printing 'acl' even if acls are
> disabled be more backward compatible?
Sorry. misparsed the patch - ignore this comment.
next prev parent reply other threads:[~2009-10-25 7:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-15 12:54 [Ocfs2-devel] [PATCH 0/3] POSIX ACL config and mount option changes Jan Kara
2009-10-15 12:54 ` [Ocfs2-devel] [PATCH 1/3] ocfs2: Make ACLs always compiled into the kernel Jan Kara
2009-10-15 13:03 ` Christoph Hellwig
2009-10-15 13:42 ` Jan Kara
2009-10-15 21:07 ` Joel Becker
2009-10-17 9:44 ` Jan Kara
2009-10-25 7:20 ` Christoph Hellwig [this message]
2009-10-15 12:54 ` [Ocfs2-devel] [PATCH 2/3] ocfs2: Change acl mount option handling Jan Kara
2009-10-15 12:54 ` [Ocfs2-devel] [PATCH 3/3] ocfs2: Set MS_POSIXACL on remount Jan Kara
2009-10-29 6:16 ` [Ocfs2-devel] [PATCH 0/3] POSIX ACL config and mount option changes Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091025072004.GB17121@lst.de \
--to=hch@lst.de \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.