From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N275z-00054E-KD
	for qemu-devel@nongnu.org; Sun, 25 Oct 2009 13:41:35 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N275v-00050P-4v
	for qemu-devel@nongnu.org; Sun, 25 Oct 2009 13:41:35 -0400
Received: from [199.232.76.173] (port=51137 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N275v-00050M-35
	for qemu-devel@nongnu.org; Sun, 25 Oct 2009 13:41:31 -0400
Received: from mail.gmx.net ([213.165.64.20]:59317)
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <dl9pf@gmx.de>) id 1N275u-0006Dj-Gk
	for qemu-devel@nongnu.org; Sun, 25 Oct 2009 13:41:30 -0400
From: "Jan-Simon =?iso-8859-1?q?M=F6ller?=" <dl9pf@gmx.de>
Subject: Re: [Qemu-devel] [Patch] Make usermode stacksize (-s) configurable at
	compile-time
Date: Sun, 25 Oct 2009 18:41:24 +0100
References: <200910251622.07800.dl9pf@gmx.de>
	<761ea48b0910250854g2aa96a49w65eb5ede77c38f51@mail.gmail.com>
In-Reply-To: <761ea48b0910250854g2aa96a49w65eb5ede77c38f51@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200910251841.25045.dl9pf@gmx.de>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Laurent Desnogues <laurent.desnogues@gmail.com>
Cc: qemu-devel@nongnu.org

Am Sonntag 25 Oktober 2009 16:54:16 schrieb Laurent Desnogues:
> Wouldn't it be better to set this earlier only if target_user_only
> is set to yes and use cflags?
> 
> Something like this:
> 
> if test "$target_user_only" = "yes" -a "$user_mode_stacksize" != ""; then
>   cflags="-DUSER_MODE_STACKSIZE $cflags"
> fi
> 
> just after the test for pie (line 2478) for instance.
Done. 
> The informative echo should go with the others (line 1853).
Its not clear at this stage, if its "default" or the cmdline value, 
as $target_user_only isn't evaluated until line 2171 .

I'd leave therefore the echo in line 2491.
> 
>
> I'd prefer:
> 
> #ifndef USER_MODE_STACKSIZE
> #define x86_stack_size (512 * 1024)
> #endif
> unsigned long x86_stack_size = USER_MODE_STACKSIZE;
> 
You mean probably?
#ifndef USER_MODE_STACKSIZE
#define USER_MODE_STACKSIZE (512 * 1024)
#endif
unsigned long x86_stack_size = USER_MODE_STACKSIZE;

Done.

Patch will follow in next mail as reply.

Tnx and have phun !

Jan-Simon