From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, gospo@redhat.com, alexander.h.duyck@intel.com
Subject: Re: [net-2.6 PATCH 1/3] igb: fix memory leak when setting ring size while interface is down
Date: Mon, 26 Oct 2009 16:09:14 -0700 (PDT) [thread overview]
Message-ID: <20091026.160914.44259149.davem@davemloft.net> (raw)
In-Reply-To: <20091026213147.9993.9778.stgit@localhost.localdomain>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 26 Oct 2009 14:31:47 -0700
> From: Alexander Duyck <alexander.h.duyck@intel.com>
>
> Changing ring sizes while the interface was down was causing a double
> allocation of the receive and transmit rings. This issue is amplified when
> there are multiple rings enabled. To prevent this we need to add an
> additional check which will just update the ring counts when the interface
> is not up and skip the allocation steps.
>
> Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
prev parent reply other threads:[~2009-10-26 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 21:31 [net-2.6 PATCH 1/3] igb: fix memory leak when setting ring size while interface is down Jeff Kirsher
2009-10-26 21:32 ` [net-2.6 PATCH 2/3] ixgbe: fix memory leak when resizing rings " Jeff Kirsher
2009-10-26 23:09 ` David Miller
2009-10-26 21:32 ` [net-2.6 PATCH 3/3] igbvf: fix memory leak when ring size changed while interface down Jeff Kirsher
2009-10-26 23:09 ` David Miller
2009-10-26 23:09 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026.160914.44259149.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=gospo@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.