From: Aurelien Jarno <aurelien@aurel32.net>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements after if/else blocks
Date: Mon, 26 Oct 2009 07:26:37 +0100 [thread overview]
Message-ID: <20091026062637.GA21562@volta.aurel32.net> (raw)
Rationale: The following code is difficult to read, but allowed by the
current coding style.
if (a == 5) printf("a was 5.\n");
else if (a == 6) printf("a was 6.\n");
else printf("a was something else entirely.\n");
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
---
CODING_STYLE | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/CODING_STYLE b/CODING_STYLE
index a579cb1..3ffbc3d 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -51,11 +51,11 @@ QEMU coding style.
4. Block structure
-Every indented statement is braced; even if the block contains just one
-statement. The opening brace is on the line that contains the control
-flow statement that introduces the new block; the closing brace is on the
-same line as the else keyword, or on a line by itself if there is no else
-keyword. Example:
+Every control flow statement is followed by a new indented and braced
+block; even if the block contains just one statement. The opening brace
+is on the line that contains the control flow statement that introduces
+the new block; the closing brace is on the same line as the else keyword,
+or on a line by itself if there is no else keyword. Example:
if (a == 5) {
printf("a was 5.\n");
--
1.6.1.3
next reply other threads:[~2009-10-26 6:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 6:26 Aurelien Jarno [this message]
2009-10-26 16:02 ` [Qemu-devel] [PATCH] CODING_STYLE: don't allow non-indented statements after if/else blocks Blue Swirl
2009-10-26 20:03 ` Aurelien Jarno
2009-10-26 20:20 ` Blue Swirl
2009-10-26 20:27 ` Aurelien Jarno
2009-10-26 21:16 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026062637.GA21562@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.