From: Andy Whitcroft <apw@canonical.com>
To: Joe Perches <joe@perches.com>
Cc: Jan Ceuleers <jan.ceuleers@computer.org>,
David Miller <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scripts/checkpatch.pl: Add WARN on sizeof(&
Date: Mon, 26 Oct 2009 11:17:22 +0000 [thread overview]
Message-ID: <20091026111722.GF12089@shadowen.org> (raw)
In-Reply-To: <1254618769.1799.280.camel@Joe-Laptop.home>
On Sat, Oct 03, 2009 at 06:12:49PM -0700, Joe Perches wrote:
> On Sat, 2009-10-03 at 17:38 +0200, Jan Ceuleers wrote:
> > David Miller wrote:
> > > Any time you see "&" in a sizeof() expression, it's almost
> > > certainly a bug. Something for the folks with automated
> > > tools to look for if they haven't already :-)
> >
> > Your remark prompted me to find four more instances of such bugs
> > (none of which in the networking bits). I have submitted patches.
>
> Perhaps a checkpatch test.
>
> ---
>
> sizeof(&foo) is frequently an error. Warn on its use.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Seems reasonable. A slightly modified version of this is now in my
tree. Thanks!
http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing
-apw
prev parent reply other threads:[~2009-10-26 11:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-02 9:30 [PATCH] net: Fix wrong sizeof Jean Delvare
2009-10-02 15:14 ` Randy Dunlap
2009-10-02 16:54 ` David Miller
2009-10-03 15:38 ` Jan Ceuleers
2009-10-04 1:12 ` [PATCH] scripts/checkpatch.pl: Add WARN on sizeof(& Joe Perches
2009-10-05 7:59 ` Américo Wang
2009-10-26 11:17 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091026111722.GF12089@shadowen.org \
--to=apw@canonical.com \
--cc=davem@davemloft.net \
--cc=jan.ceuleers@computer.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.