All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: [WARNING] pxamci: 'pxa2xx-mci.0' does not have a release() function.
Date: Mon, 26 Oct 2009 09:58:52 -0700	[thread overview]
Message-ID: <20091026165852.GC18218@kroah.com> (raw)
In-Reply-To: <20091023101806.GB19437@n2100.arm.linux.org.uk>

On Fri, Oct 23, 2009 at 11:18:06AM +0100, Russell King - ARM Linux wrote:
> On Fri, Oct 23, 2009 at 11:50:28AM +0200, Antonio Ospite wrote:
> > On Thu, 22 Oct 2009 23:57:58 +0100
> > Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> > 
> > > On Fri, Oct 23, 2009 at 12:36:31AM +0200, Antonio Ospite wrote:
> > > > Hi,
> > > > 
> > > > I get this warning on shutdown. How to fix it properly?
> > > > 
> > > > FYI, in my setup pxa2xx_spi is the parent for pxamci, set using
> > > > this patch:
> > > > http://git.openezx.org/openezx.git?a=commitdiff;h=0ffd85ad8faea3456d4ecf5f63ae65aca26fff21
> > > 
> > > This sounds like it's the cause of the problem - from the backtrace, it
> > > looks like SPI expects the children of the SPI device to be its own
> > > responsibility to maintain.
> > > 
> > > Hence, because you've made pxamci a child of SPI, SPI is trying to
> > > unregister and release the pxamci device.
> > 
> > A little more background: we need pxamci to be a child of SPI because
> > our PMIC is connected via SPI, and a PMIC regulator is used for mmc
> > powering; enforcing this hierarchy is needed to make pxamci suspend and
> > resume properly.
> 
> I don't think this is the right solution - and I don't know what the
> right solution would be given that the interfaces I suspect you need
> aren't public.
> 
> I don't think you can reverse the order of SPI and MMC initialization
> because that'd mean MMC could try to use SPI before it exists.
> 
> Maybe the right answer is for SPI to stop thinking it owns all child
> devices, and only unregister devices which it owns (iow, are of some
> SPI bus-type.)
> 
> Adding Greg for comment.

Um, why not ask the SPI maintainer?  I don't know what the SPI code is
doing, sorry.

thanks,

greg k-h

  reply	other threads:[~2009-10-26 16:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22 22:36 [WARNING] pxamci: 'pxa2xx-mci.0' does not have a release() function Antonio Ospite
2009-10-22 22:48 ` Eric Miao
2009-10-22 22:57 ` Russell King - ARM Linux
2009-10-23  9:50   ` Antonio Ospite
2009-10-23 10:18     ` Russell King - ARM Linux
2009-10-26 16:58       ` Greg KH [this message]
2009-10-26 18:48         ` Mark Brown
2009-10-26 18:52           ` Greg KH
2009-10-26 19:22           ` Antonio Ospite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091026165852.GC18218@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.